Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement Combobox component #320

Closed
4 tasks done
krzysztofzuraw opened this issue Mar 23, 2023 · 3 comments · Fixed by #342
Closed
4 tasks done

Implement Combobox component #320

krzysztofzuraw opened this issue Mar 23, 2023 · 3 comments · Fixed by #342
Assignees
@krzysztofzuraw
Labels
next Next version of Macaw UI

Comments

@krzysztofzuraw
Copy link
Member

krzysztofzuraw commented Mar 23, 2023 •
edited

What I'm trying to achieve

I want to have the Combobox component in the new MacawUI

Describe a proposed solution

Combine the existing Input component and Downshift library to create the Select component

Tasks
Beta Give feedback

Acceptance Criteria

Screenshots or mockups

image (1)
@krzysztofzuraw krzysztofzuraw added the next Next version of Macaw UI label Mar 23, 2023
@krzysztofzuraw krzysztofzuraw self-assigned this Mar 30, 2023
@krzysztofzuraw krzysztofzuraw changed the title Implement Select component Implement Combobox component Apr 3, 2023
@krzysztofzuraw
Copy link
Member Author

krzysztofzuraw commented Apr 5, 2023 •
edited

Link for preview: https://macaw-ui-next-guq22ee8q-saleorcommerce.vercel.app/?path=/story/components-combobox--default @pflis1

@timuric
Copy link
Member

timuric commented Apr 5, 2023

Looks like incorrect state

Image

@timuric
Copy link
Member

timuric commented Apr 6, 2023

No pointer cursor on this element

Image

@krzysztofzuraw krzysztofzuraw linked a pull request Apr 6, 2023 that will close this issue
Add Combobox component #342
Merged
@krzysztofzuraw krzysztofzuraw mentioned this issue Apr 14, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@krzysztofzuraw krzysztofzuraw

Labels
next Next version of Macaw UI
Projects
Dashboard
Status: ✅ Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add Combobox component saleor/macaw-ui
2 participants
@timuric @krzysztofzuraw