Change Sidebar and SidebarDrawer to allow custom Link component #132
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Task linked: SALEOR-6324 Add links to rows |
|
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/saleorcommerce/macaw-ui/CYzCSkuWaVRjjTesqT3mV9Q1qyTe |
size-limit report 📦
|
witoszekdev
requested review from
a team,
dominik-zeglen and
Cloud11PL
and removed request for
a team
Cloud11PL
approved these changes
Apr 7, 2022
5 tasks
dominik-zeglen
approved these changes
Apr 14, 2022
dominik-zeglen
approved these changes
Apr 15, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I want to merge this change in order to use custom Link component (for example from react-router) in Sidebar and SidebarDrawer so that we can open links from
Sidebarand Logo insideSidebarin new tab using Cmd+click