Skip to content
This repository has been archived by the owner on Feb 10, 2023. It is now read-only.

Update app-sdk and rewrite webhook to new api #23

Closed
wants to merge 4 commits into from

Conversation

lkostrowski
Copy link
Member

@lkostrowski lkostrowski commented Nov 4, 2022

Wait for sdk 0.19.0

lkostrowski and others added 2 commits October 26, 2022 17:01
* Update app sdk paths to avoid root imports

* Update app-sdk to 0.18.0
@lkostrowski lkostrowski requested review from a team and krzysztofzuraw November 4, 2022 09:31
@vercel
Copy link

vercel bot commented Nov 4, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
saleor-app-slack ✅ Ready (Inspect) Visit Preview Dec 6, 2022 at 1:37PM (UTC)

const errorMessage = await response.text();
console.error(`Slack API responded with code ${response.status}: ${errorMessage}`);

return Response.InternalServerError({
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are retes responses compatible inside the next handlers? 🤔

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

probably not, I copied it from original code, will change

Copy link
Member

@krzysztofwolski krzysztofwolski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lookin good!

@lkostrowski
Copy link
Member Author

Closing in favor of #27

@lkostrowski lkostrowski closed this Dec 6, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
No open projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants