Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update savebar design #690

Merged
merged 3 commits into from
Sep 4, 2020
Merged

Update savebar design #690

merged 3 commits into from
Sep 4, 2020

Conversation

dominik-zeglen
Copy link
Contributor

@dominik-zeglen dominik-zeglen commented Sep 3, 2020 •
edited
Loading

I want to merge this change because it updates savebar design. Also updates background color.

PR intended to be tested with API branch: master

Screenshots

Screenshot 2020-09-03 at 19 06 32

Screenshot 2020-09-03 at 19 06 38

Pull Request Checklist

  1. All visible strings are translated with proper context.
  2. All data-formatting is locale-aware (dates, numbers, and so on).
  3. Translated strings are extracted.
  4. Number of API calls is optimized.
  5. The changes are tested.
  6. Data-test are added for new elements.
  7. Type definitions are up to date.
  8. Changes are mentioned in the changelog.

Test environment config

API_URI=https://master.staging.saleor.rocks/graphql/

@github-actions github-actions bot temporarily deployed to ref-savebar September 3, 2020 17:03 Inactive
@github-actions github-actions bot temporarily deployed to ref-savebar September 3, 2020 17:04 Inactive
@patrys
Copy link
Member

patrys commented Sep 3, 2020

Task linked: CU-7un556 Implement new floating element

@patrys
Copy link
Member

patrys commented Sep 3, 2020

Task linked: CU-7umwen Update background

@github-actions github-actions bot temporarily deployed to ref-savebar September 3, 2020 17:07 Inactive
krzysztofwolski
krzysztofwolski approved these changes Sep 3, 2020
View reviewed changes
Copy link
Member

@krzysztofwolski krzysztofwolski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lookin good, theres even fade out animation for shadow 😎

@dominik-zeglen dominik-zeglen merged commit 591f2ec into master Sep 4, 2020
@dominik-zeglen dominik-zeglen deleted the ref/savebar branch September 4, 2020 11:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@krzysztofwolski krzysztofwolski krzysztofwolski approved these changes

@AlicjaSzu AlicjaSzu AlicjaSzu approved these changes

@orzechdev orzechdev Awaiting requested review from orzechdev

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@dominik-zeglen @patrys @krzysztofwolski @AlicjaSzu