Add documentation for Emails and Messages app #821
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
krzysztofwolski
commented
Jul 6, 2023
krzysztofwolski
commented
- Add Emails and Messages documentation
- Sort app cards on the overview page
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
6 tasks
lkostrowski
reviewed
Jul 6, 2023
| - use only the specific channels | ||
| - use all channels except the specific ones | ||
|
|
||
| ## Development |
There was a problem hiding this comment.
probably worth linking https://docs.saleor.io/docs/3.x/developer/app-store/development
and leave here only app specific stuff
peelar
requested changes
Jul 7, 2023
|
|
||
| ## Supported events | ||
|
|
||
| The application is listening to the following events: |
There was a problem hiding this comment.
question:
What type of events are these? Because I don't see them on the webhook events list.
There was a problem hiding this comment.
The list was copied from old plugin.
Reorganized this section to contain more info on where those events come from and added links for non-trivial topics like activating the account. WDYT?
docs/developer/app-store/apps/emails-and-messages/troubleshooting.mdx
Outdated
Show resolved
Hide resolved
|
@krzysztofwolski could we move this forward? |
Co-authored-by: Adrian Pilarczyk <adrianpilarczyk314@gmail.com>
Co-authored-by: Adrian Pilarczyk <adrianpilarczyk314@gmail.com>
peelar
requested changes
Jul 12, 2023
docs/developer/app-store/apps/emails-and-messages/troubleshooting.mdx
Outdated
Show resolved
Hide resolved
krzysztofwolski
commented
Jul 12, 2023
krzysztofwolski
commented
Jul 12, 2023
krzysztofwolski
commented
Jul 12, 2023
krzysztofwolski
commented
Jul 12, 2023
krzysztofwolski
commented
Jul 12, 2023
krzysztofwolski
commented
Jul 12, 2023
docs/developer/app-store/apps/emails-and-messages/troubleshooting.mdx
Outdated
Show resolved
Hide resolved
krzysztofwolski
commented
Jul 12, 2023
docs/developer/app-store/apps/emails-and-messages/troubleshooting.mdx
Outdated
Show resolved
Hide resolved
krzysztofwolski
commented
Jul 12, 2023
Co-authored-by: Adrian Pilarczyk <adrianpilarczyk314@gmail.com>
peelar
approved these changes
Jul 12, 2023
|
@zaiste code owner review required to merge. Could you take a look? |
peelar
reviewed
Jul 12, 2023
|
|
||
| 1. Create an account at [MailSlurp](https://www.mailslurp.com/) | ||
| 2. Create a new inbox - [documentation](https://www.mailslurp.com/guides/creating-inboxes/) | ||
| 3. Use the inbox address to create a new sender in Sendgrid - [documentation](https://docs.sendgrid.com/ui/sending-email/senders) |
There was a problem hiding this comment.
polish: I think it looks nicer to link to the docs right from the corresponding fragment.
Suggested change
| 3. Use the inbox address to create a new sender in Sendgrid - [documentation](https://docs.sendgrid.com/ui/sending-email/senders) | |
| 3. Use the inbox address to [create a new sender in Sendgrid](https://docs.sendgrid.com/ui/sending-email/senders) |
krzysztofwolski
commented
Jul 12, 2023
peelar
approved these changes
Jul 12, 2023
lkostrowski
approved these changes
Jul 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.