Updated bootstrap to 4.0.0-beta #1113
Conversation
| svg { | ||
| max-height: 25px; | ||
| width: auto; | ||
| } | ||
| } | ||
| &__login { | ||
| width: 100%; |
There was a problem hiding this comment.
Why do we suddenly have to set width on so many selectors?
There was a problem hiding this comment.
Beacuse bootstrap's .container class has fixed max-width and width: 100% since beta. In alpha .container had fixed width and max-width: 100%.
There was a problem hiding this comment.
I'm confused. So you're saying that it already has the correct width?
There was a problem hiding this comment.
I'm saying that we need to set width on the parent element since .container is now scaling with the parent, not the other way like it used to be before.
Codecov Report
@@ Coverage Diff @@
## master #1113 +/- ##
=======================================
Coverage 63.65% 63.65%
=======================================
Files 106 106
Lines 5869 5869
Branches 729 729
=======================================
Hits 3736 3736
Misses 1994 1994
Partials 139 139Continue to review full report at Codecov.
|
|
@dominik-zeglen Please link to any related issues when opening a pull request, this time I've edited the original comment for you. |
Fixes: #1112, #1086