-
Notifications
You must be signed in to change notification settings - Fork 5.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update frontend dependencies #1115
Update frontend dependencies #1115
Conversation
It looks like part of this PR is also covered by PR #1113. Could you make sure that we don't double commits in two different pull requests? |
Also please follow this guidelines for writing commit messages. |
It seems that CI fails: https://travis-ci.org/mirumee/saleor/builds/274641837 |
@dominik-zeglen Once you fix CI please rewrite the commits to follow what @elwoodxblues suggested. |
Codecov Report
@@ Coverage Diff @@
## master #1115 +/- ##
=======================================
Coverage 67.68% 67.68%
=======================================
Files 114 114
Lines 6140 6140
Branches 747 747
=======================================
Hits 4156 4156
Misses 1812 1812
Partials 172 172
Continue to review full report at Codecov.
|
I think we could also bump the version of Yarn in this PR. |
With new "materialize-css" version = 0.100.2 not working checkbox in dashboard |
@@ -81,18 +80,18 @@ var config = { | |||
{ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You should use module.rules
instead of old module.loaders
syntax.
https://webpack.js.org/guides/migrating/#module-loaders-is-now-module-rules
Closes #1114