Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update frontend dependencies #1115

Merged
merged 23 commits into from
Sep 26, 2017
Merged

Update frontend dependencies #1115

merged 23 commits into from
Sep 26, 2017

Conversation

dominik-zeglen
Copy link
Contributor

@dominik-zeglen dominik-zeglen commented Sep 12, 2017

Closes #1114

@maarcingebala
Copy link
Member

It looks like part of this PR is also covered by PR #1113. Could you make sure that we don't double commits in two different pull requests?

@maarcingebala
Copy link
Member

Also please follow this guidelines for writing commit messages.

@patrys
Copy link
Member

patrys commented Sep 12, 2017

It seems that CI fails: https://travis-ci.org/mirumee/saleor/builds/274641837

@patrys
Copy link
Member

patrys commented Sep 12, 2017

@dominik-zeglen Once you fix CI please rewrite the commits to follow what @elwoodxblues suggested.

@codecov-io
Copy link

codecov-io commented Sep 13, 2017

Codecov Report

Merging #1115 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1115   +/-   ##
=======================================
  Coverage   67.68%   67.68%           
=======================================
  Files         114      114           
  Lines        6140     6140           
  Branches      747      747           
=======================================
  Hits         4156     4156           
  Misses       1812     1812           
  Partials      172      172
Impacted Files Coverage Δ
saleor/graphql/api.py 81.92% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8c4c039...f40c5b1. Read the comment docs.

@maarcingebala
Copy link
Member

I think we could also bump the version of Yarn in this PR.

@ghost
Copy link

ghost commented Sep 19, 2017

With new "materialize-css" version = 0.100.2 not working checkbox in dashboard

@@ -81,18 +80,18 @@ var config = {
{
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You should use module.rules instead of old module.loaders syntax.
https://webpack.js.org/guides/migrating/#module-loaders-is-now-module-rules

@maarcingebala maarcingebala merged commit e610fdb into saleor:master Sep 26, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants