Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix OIDC plugin crashing when given a JWT without an exp claim #11820

Merged
merged 1 commit into from
Jan 26, 2023
Merged

Fix OIDC plugin crashing when given a JWT without an exp claim #11820

merged 1 commit into from
Jan 26, 2023

Conversation

patrys
Copy link
Member

@patrys patrys commented Jan 26, 2023

This is a port of #11814 to Saleor 3.8

Impact

  • New migrations
  • New/Updated API fields or mutations
  • Deprecated API fields or mutations
  • Removed API types, fields, or mutations
  • Documentation needs to be updated

Pull Request Checklist

  • Privileged queries and mutations are guarded by proper permission checks
  • Database queries are optimized and the number of queries is constant
  • Database migration files are up to date
  • The changes are tested
  • GraphQL schema and type definitions are up to date
  • Changes are mentioned in the changelog

@patrys patrys requested a review from a team as a code owner January 26, 2023 12:02
@patrys patrys changed the base branch from main to 3.8 January 26, 2023 12:03
@patrys patrys requested a review from a team January 26, 2023 12:06
@patrys patrys requested review from a team and removed request for a team January 26, 2023 12:57
@maarcingebala maarcingebala merged commit f392736 into 3.8 Jan 26, 2023
@maarcingebala maarcingebala deleted the fix-oidc-handling-tokens-without-exp-claims-38 branch January 26, 2023 12:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maarcingebala maarcingebala maarcingebala approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@patrys @maarcingebala