Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

1627 checkout improvement #1643

Merged
merged 2 commits into from
Jan 22, 2018
Merged

1627 checkout improvement #1643

merged 2 commits into from
Jan 22, 2018

Conversation

akjanik
Copy link
Contributor

@akjanik akjanik commented Jan 19, 2018

Fixes #1627

Before
checkout_b4

After
checkout_after

Pull Request Checklist

(Please keep this section. It will make maintainer's life easier.)

  1. Privileged views and APIs are guarded by proper permission checks.
  2. All visible strings are translated with proper context.
  3. All data-formatting is locale-aware (dates, numbers, and so on).
  4. Database queries are optimized and the number of queries is constant.
  5. The changes are tested.
  6. The code is documented (docstrings, project documentation).
  7. Python code quality checks pass: pycodestyle, pydocstyle, pylint.
  8. JavaScript code quality checks pass: eslint.

@akjanik akjanik added this to the 2018.01 milestone Jan 19, 2018
@akjanik akjanik self-assigned this Jan 19, 2018
@codecov-io
Copy link

codecov-io commented Jan 19, 2018

Codecov Report

Merging #1643 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1643   +/-   ##
=======================================
  Coverage   82.54%   82.54%           
=======================================
  Files         136      136           
  Lines        5913     5913           
  Branches      650      650           
=======================================
  Hits         4881     4881           
  Misses        866      866           
  Partials      166      166

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d2c6a96...1130690. Read the comment docs.

@maarcingebala maarcingebala merged commit ca93e81 into master Jan 22, 2018
@maarcingebala maarcingebala deleted the 1627_checkout_improvement branch January 22, 2018 09:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants