Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Display not found page after getting null from API #3463

Merged
merged 10 commits into from Dec 18, 2018

Conversation

dominik-zeglen
Copy link
Contributor

@dominik-zeglen dominik-zeglen commented Dec 14, 2018

Resolves #3105

Pull Request Checklist

  1. Privileged views and APIs are guarded by proper permission checks.
  2. All visible strings are translated with proper context.
  3. All data-formatting is locale-aware (dates, numbers, and so on).
  4. Database queries are optimized and the number of queries is constant.
  5. Database migration files are up to date.
  6. The changes are tested.
  7. The code is documented (docstrings, project documentation).
  8. GraphQL schema and type definitions are up to date.
  9. Changes are mentioned in the changelog.

@dominik-zeglen
Copy link
Contributor Author

@pwgryglak we need some design for this

@codecov
Copy link

codecov bot commented Dec 14, 2018

Codecov Report

Merging #3463 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #3463   +/-   ##
=======================================
  Coverage   89.87%   89.87%           
=======================================
  Files         241      241           
  Lines       13103    13103           
  Branches     1322     1322           
=======================================
  Hits        11776    11776           
  Misses        922      922           
  Partials      405      405

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ac74179...098e752. Read the comment docs.

@maarcingebala maarcingebala merged commit 1ef4e22 into master Dec 18, 2018
@maarcingebala maarcingebala deleted the add-object-not-found branch December 18, 2018 15:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants