New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Display not found page after getting null from API #3463
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@pwgryglak we need some design for this |
Codecov Report
@@ Coverage Diff @@
## master #3463 +/- ##
=======================================
Coverage 89.87% 89.87%
=======================================
Files 241 241
Lines 13103 13103
Branches 1322 1322
=======================================
Hits 11776 11776
Misses 922 922
Partials 405 405 Continue to review full report at Codecov.
|
maarcingebala
approved these changes
Dec 17, 2018
dominik-zeglen
force-pushed
the
add-object-not-found
branch
from
December 18, 2018 10:40
026db67
to
24b2d69
Compare
piotrgrundas
approved these changes
Dec 18, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #3105
Pull Request Checklist