Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Display not found page after getting null from API #3463

Merged
merged 10 commits into from
Dec 18, 2018
Merged

Display not found page after getting null from API #3463

merged 10 commits into from
Dec 18, 2018

Commits on Dec 18, 2018

  1. Add check if all required objects were found

    @dominik-zeglen
    dominik-zeglen committed Dec 18, 2018
    Configuration menu
    Copy the full SHA
    3cc0fed View commit details
    Browse the repository at this point in the history

  2. Use null rather than just falsy value

    @dominik-zeglen
    dominik-zeglen committed Dec 18, 2018
    Configuration menu
    Copy the full SHA
    70fa933 View commit details
    Browse the repository at this point in the history

  3. Display object not found if query returned null

    @dominik-zeglen
    dominik-zeglen committed Dec 18, 2018
    Configuration menu
    Copy the full SHA
    835670d View commit details
    Browse the repository at this point in the history

  4. Add data check

    @dominik-zeglen
    dominik-zeglen committed Dec 18, 2018
    Configuration menu
    Copy the full SHA
    be1b117 View commit details
    Browse the repository at this point in the history

  5. Update changelog

    @dominik-zeglen
    dominik-zeglen committed Dec 18, 2018
    Configuration menu
    Copy the full SHA
    955857c View commit details
    Browse the repository at this point in the history

  6. Add proper error page

    @dominik-zeglen
    dominik-zeglen committed Dec 18, 2018
    Configuration menu
    Copy the full SHA
    f20a9a0 View commit details
    Browse the repository at this point in the history

  7. Add story

    @dominik-zeglen
    dominik-zeglen committed Dec 18, 2018
    Configuration menu
    Copy the full SHA
    2fb6b92 View commit details
    Browse the repository at this point in the history

  8. Update tests

    @dominik-zeglen
    dominik-zeglen committed Dec 18, 2018
    Configuration menu
    Copy the full SHA
    24b2d69 View commit details
    Browse the repository at this point in the history

  9. Merge branch 'master' into add-object-not-found

    @maarcingebala
    maarcingebala committed Dec 18, 2018
    Configuration menu
    Copy the full SHA
    d4ddcbc View commit details
    Browse the repository at this point in the history

  10. Merge branch 'master' into add-object-not-found

    @maarcingebala
    maarcingebala committed Dec 18, 2018
    Configuration menu
    Copy the full SHA
    098e752 View commit details
    Browse the repository at this point in the history