Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix simple product editing #3474

Merged
merged 5 commits into from Dec 18, 2018
Merged

Fix simple product editing #3474

merged 5 commits into from Dec 18, 2018

Conversation

dominik-zeglen
Copy link
Contributor

Resolves #3452
Resolves #3437

Pull Request Checklist

  1. Privileged views and APIs are guarded by proper permission checks.
  2. All visible strings are translated with proper context.
  3. All data-formatting is locale-aware (dates, numbers, and so on).
  4. Database queries are optimized and the number of queries is constant.
  5. Database migration files are up to date.
  6. The changes are tested.
  7. The code is documented (docstrings, project documentation).
  8. GraphQL schema and type definitions are up to date.
  9. Changes are mentioned in the changelog.

@codecov
Copy link

codecov bot commented Dec 17, 2018

Codecov Report

Merging #3474 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #3474   +/-   ##
=======================================
  Coverage   89.75%   89.75%           
=======================================
  Files         237      237           
  Lines       12943    12943           
  Branches     1312     1312           
=======================================
  Hits        11617    11617           
  Misses        922      922           
  Partials      404      404

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2111d8f...c44f1c2. Read the comment docs.

@codecov
Copy link

codecov bot commented Dec 17, 2018

Codecov Report

❗ No coverage uploaded for pull request base (master@599c46d). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #3474   +/-   ##
=========================================
  Coverage          ?   89.75%           
=========================================
  Files             ?      237           
  Lines             ?    12949           
  Branches          ?     1313           
=========================================
  Hits              ?    11622           
  Misses            ?      922           
  Partials          ?      405

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 599c46d...aaa56dc. Read the comment docs.

@maarcingebala maarcingebala merged commit 0ded2ff into master Dec 18, 2018
@maarcingebala maarcingebala deleted the fix-simple-products branch December 18, 2018 15:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants