Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix collection homepage assigining #3481

Merged
merged 6 commits into from Dec 20, 2018
Merged

Conversation

dominik-zeglen
Copy link
Contributor

@dominik-zeglen dominik-zeglen commented Dec 18, 2018

I want to merge this change because it changes how 'Feature on Homepage' switch behaves - from in-place mutation to waiting for confirmation by 'Save' button.
Build on top of #3474

Pull Request Checklist

  1. Privileged views and APIs are guarded by proper permission checks.
  2. All visible strings are translated with proper context.
  3. All data-formatting is locale-aware (dates, numbers, and so on).
  4. Database queries are optimized and the number of queries is constant.
  5. Database migration files are up to date.
  6. The changes are tested.
  7. The code is documented (docstrings, project documentation).
  8. GraphQL schema and type definitions are up to date.
  9. Changes are mentioned in the changelog.

@codecov
Copy link

codecov bot commented Dec 18, 2018

Codecov Report

Merging #3481 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #3481   +/-   ##
=======================================
  Coverage   89.89%   89.89%           
=======================================
  Files         241      241           
  Lines       13109    13109           
  Branches     1323     1323           
=======================================
  Hits        11784    11784           
  Misses        921      921           
  Partials      404      404

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 11f30e1...18f29fd. Read the comment docs.

@maarcingebala maarcingebala merged commit 14e8590 into master Dec 20, 2018
@maarcingebala maarcingebala deleted the fix-collection-homepage branch December 20, 2018 13:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants