-
Notifications
You must be signed in to change notification settings - Fork 5.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change max length of SKU to 255 #4811
Conversation
Here is the report for 0691c00 (lex111/saleor @ sku-255) No differences were found. (click me)
# api.benchmark checkout
test name left count right count duplicate count
------------------------------------------- ----------- ----------- ---------------
add billing address to checkout 34 34 20
add shipping to checkout 7 7 0
checkout payment charge 14 14 0
complete checkout 6 6 0
create checkout 48 48 24
# api.benchmark homepage
test name left count right count duplicate count
------------------------------------------- ----------- ----------- ---------------
retrieve main menu 5 5 0
retrieve product list 4 4 0
retrieve secondary menu 5 5 0
retrieve shop 2 2 0
# api.benchmark product
test name left count right count duplicate count
------------------------------------------- ----------- ----------- ---------------
product details 15 15 3
retrieve product attributes 13 13 2
# api.benchmark variant
test name left count right count duplicate count
------------------------------------------- ----------- ----------- ---------------
retrieve variant list 18 18 8
# api product sorting attributes
test name left count right count duplicate count
------------------------------------------- ----------- ----------- ---------------
sort product not having attribute data 21 21 0 |
Thanks for opening the PR! Changes look good but there are two minor things to fix:
|
Codecov Report
@@ Coverage Diff @@
## master #4811 +/- ##
=======================================
Coverage 91.24% 91.24%
=======================================
Files 344 344
Lines 20616 20616
Branches 1956 1956
=======================================
Hits 18812 18812
Misses 1266 1266
Partials 538 538
Continue to review full report at Codecov.
|
@maarcingebala thanks to you, too! I really wanted to update Russian localization, there are enough mistakes, but I can not test this locally via Docker. I understand that you are using Transifex, but I cannot change and see update locale? In general, would it be easier for me to open a PR with my edits rather than to do this on Transifex, or can I upload my file (*.po) into this service? |
@lex111 I believe you should be able to do it, I don't think there are special permissions to be able to. That's how I used to do: https://docs.transifex.com/translation/importing-translations |
@NyanKiyoshi cool, I’ll definitely try when I finish the translation. But it’s bad that now I can’t see my changes locally :( |
I want to merge this change because...
Resolves #4389
Pull Request Checklist