Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change max length of SKU to 255 #4811

Merged
merged 3 commits into from
Oct 7, 2019
Merged

Conversation

lex111
Copy link
Contributor

@lex111 lex111 commented Oct 6, 2019

I want to merge this change because...

Resolves #4389

Pull Request Checklist

  1. Privileged views and APIs are guarded by proper permission checks.
  2. All visible strings are translated with proper context.
  3. All data-formatting is locale-aware (dates, numbers, and so on).
  4. Database queries are optimized and the number of queries is constant.
  5. Database migration files are up to date.
  6. The changes are tested.
  7. GraphQL schema and type definitions are up to date.
  8. Changes are mentioned in the changelog.

Copy link

django-queries commented Oct 6, 2019

Here is the report for 0691c00 (lex111/saleor @ sku-255)
Base comparison is d54fd99.

No differences were found. (click me)

# api.benchmark checkout
  test name                                  	left count 	right count	duplicate count
  -------------------------------------------	-----------	-----------	---------------
  add billing address to checkout            	         34	         34	             20
  add shipping to checkout                   	          7	          7	              0
  checkout payment charge                    	         14	         14	              0
  complete checkout                          	          6	          6	              0
  create checkout                            	         48	         48	             24

# api.benchmark homepage
  test name                                  	left count 	right count	duplicate count
  -------------------------------------------	-----------	-----------	---------------
  retrieve main menu                         	          5	          5	              0
  retrieve product list                      	          4	          4	              0
  retrieve secondary menu                    	          5	          5	              0
  retrieve shop                              	          2	          2	              0

# api.benchmark product
  test name                                  	left count 	right count	duplicate count
  -------------------------------------------	-----------	-----------	---------------
  product details                            	         15	         15	              3
  retrieve product attributes                	         13	         13	              2

# api.benchmark variant
  test name                                  	left count 	right count	duplicate count
  -------------------------------------------	-----------	-----------	---------------
  retrieve variant list                      	         18	         18	              8

# api product sorting attributes
  test name                                  	left count 	right count	duplicate count
  -------------------------------------------	-----------	-----------	---------------
  sort product not having attribute data     	         21	         21	              0

@maarcingebala
Copy link
Member

Thanks for opening the PR! Changes look good but there are two minor things to fix:

  • please apply Black to your changes (it's failing on CI now),
  • update the CHANGELOG.md by adding an entry in the "Unreleased" section with the description of your changes, a number of the PR and you Github handle (see at other entries).

@codecov
Copy link

codecov bot commented Oct 7, 2019

Codecov Report

Merging #4811 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #4811   +/-   ##
=======================================
  Coverage   91.24%   91.24%           
=======================================
  Files         344      344           
  Lines       20616    20616           
  Branches     1956     1956           
=======================================
  Hits        18812    18812           
  Misses       1266     1266           
  Partials      538      538
Impacted Files Coverage Δ
saleor/order/models.py 90.98% <100%> (ø) ⬆️
saleor/product/models.py 93.77% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d54fd99...0691c00. Read the comment docs.

@maarcingebala maarcingebala merged commit 2fdc874 into saleor:master Oct 7, 2019
@maarcingebala
Copy link
Member

🎉 Thanks for your contribution and for participating in Hacktoberfest! Please send me your shipping address to marcin@mirumee.com and we'll send you our Ultra-Fast Socks:

EF328rvXYAggNhc

@lex111
Copy link
Contributor Author

lex111 commented Oct 7, 2019

@maarcingebala thanks to you, too! I really wanted to update Russian localization, there are enough mistakes, but I can not test this locally via Docker. I understand that you are using Transifex, but I cannot change and see update locale? In general, would it be easier for me to open a PR with my edits rather than to do this on Transifex, or can I upload my file (*.po) into this service?

@lex111 lex111 deleted the sku-255 branch October 7, 2019 13:06
@NyanKiyoshi
Copy link
Member

NyanKiyoshi commented Oct 7, 2019

@lex111 I believe you should be able to do it, I don't think there are special permissions to be able to. That's how I used to do: https://docs.transifex.com/translation/importing-translations

@lex111
Copy link
Contributor Author

lex111 commented Oct 7, 2019

@NyanKiyoshi cool, I’ll definitely try when I finish the translation. But it’s bad that now I can’t see my changes locally :(

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Current Product Variant SKU is too short
4 participants