-
Notifications
You must be signed in to change notification settings - Fork 5.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Unify meta mutations #5178
Unify meta mutations #5178
Conversation
735729d
to
dae3d15
Compare
Codecov Report
@@ Coverage Diff @@
## master #5178 +/- ##
==========================================
+ Coverage 91.51% 91.56% +0.04%
==========================================
Files 277 283 +6
Lines 17899 18141 +242
Branches 1562 1575 +13
==========================================
+ Hits 16380 16610 +230
- Misses 1104 1108 +4
- Partials 415 423 +8
Continue to review full report at Codecov.
|
Here is the report for 67a46a3 (mirumee/saleor @ 5028/Unify_meta_mutations) No differences were found. (click me)
# api.benchmark checkout
test name left count right count duplicate count
------------------------------------------- ----------- ----------- ---------------
add billing address to checkout 34 34 20
add shipping to checkout 7 7 0
checkout payment charge 10 10 0
complete checkout 8 8 0
create checkout 5 5 1
# api.benchmark homepage
test name left count right count duplicate count
------------------------------------------- ----------- ----------- ---------------
retrieve main menu 5 5 0
retrieve product list 4 4 0
retrieve secondary menu 5 5 0
retrieve shop 2 2 0
# api.benchmark product
test name left count right count duplicate count
------------------------------------------- ----------- ----------- ---------------
product details 17 17 3
retrieve product attributes 9 9 0
# api.benchmark variant
test name left count right count duplicate count
------------------------------------------- ----------- ----------- ---------------
product variant bulk create 51 51 3
retrieve variant list 23 23 9
# api product sorting attributes
test name left count right count duplicate count
------------------------------------------- ----------- ----------- ---------------
sort product not having attribute data 21 21 0 |
4ff6566
to
5875fb7
Compare
23ab6ea
to
ec3ec69
Compare
5e7ef54
to
b993606
Compare
This pull request introduces 2 alerts and fixes 1 when merging b993606 into b0810a5 - view on LGTM.com new alerts:
fixed alerts:
|
c2df224
to
10c82d3
Compare
This pull request fixes 1 alert when merging 10c82d3 into b0810a5 - view on LGTM.com fixed alerts:
|
This pull request fixes 1 alert when merging 35a612e into 8109634 - view on LGTM.com fixed alerts:
|
This pull request fixes 1 alert when merging 9c7352b into 00284d0 - view on LGTM.com fixed alerts:
|
This pull request fixes 1 alert when merging 28ead36 into 00284d0 - view on LGTM.com fixed alerts:
|
This pull request fixes 1 alert when merging fae262d into 73f40eb - view on LGTM.com fixed alerts:
|
This pull request fixes 1 alert when merging c9dac4c into 9591496 - view on LGTM.com fixed alerts:
|
This pull request fixes 1 alert when merging 05b0fa753b295dc846ce5fa8abcd3e9af2a13436 into 9591496 - view on LGTM.com fixed alerts:
|
05b0fa7
to
0f470cf
Compare
This pull request fixes 1 alert when merging 0f470cf into 9591496 - view on LGTM.com fixed alerts:
|
Co-Authored-By: IKarbowiak <40886528+IKarbowiak@users.noreply.github.com> Co-Authored-By: Marcin Gębala <5421321+maarcingebala@users.noreply.github.com>
19b70e6
to
67a46a3
Compare
This pull request fixes 1 alert when merging 67a46a3 into c063595 - view on LGTM.com fixed alerts:
|
I want to merge this change because resolve #5028
TODO:
Screenshots
Pull Request Checklist