Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unify meta mutations #5178

Merged
merged 20 commits into from
Feb 21, 2020
Merged

Unify meta mutations #5178

merged 20 commits into from
Feb 21, 2020

Conversation

fowczarek
Copy link
Member

@fowczarek fowczarek commented Jan 20, 2020

I want to merge this change because resolve #5028

TODO:

  1. Replace inheritances with interfaces for metadata implementation.
  2. Create a separate module for meta.
  3. Create a new mutation for update public meta.
  4. Create a new mutation for clear public meta.
  5. Flatten the metadata structure(Data migration, Mutation.itp)
  6. Create a new mutation for update private meta.
  7. Create a new mutation for clear private meta.
  8. Remove len form checkout.
  9. Create an issue to remove deprecated code.
  10. Mark old mutation, queries, functions and tests as deprecated.
  11. Add metadata mutations for draft orders(Add metadata mutations for draft orders #5171).

Screenshots

Pull Request Checklist

  1. Privileged views and APIs are guarded by proper permission checks.
  2. All visible strings are translated with proper context.
  3. All data-formatting is locale-aware (dates, numbers, and so on).
  4. Database queries are optimized and the number of queries is constant.
  5. Database migration files are up to date.
  6. The changes are tested.
  7. GraphQL schema and type definitions are up to date.
  8. Changes are mentioned in the changelog.

@codecov
Copy link

codecov bot commented Jan 20, 2020

Codecov Report

Merging #5178 into master will increase coverage by 0.04%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #5178      +/-   ##
==========================================
+ Coverage   91.51%   91.56%   +0.04%     
==========================================
  Files         277      283       +6     
  Lines       17899    18141     +242     
  Branches     1562     1575      +13     
==========================================
+ Hits        16380    16610     +230     
- Misses       1104     1108       +4     
- Partials      415      423       +8     
Impacted Files Coverage Δ
saleor/graphql/meta/deprecated/resolvers.py 100.00% <0.00%> (ø)
saleor/graphql/meta/types.py 100.00% <0.00%> (ø)
saleor/graphql/meta/resolvers.py 87.09% <0.00%> (ø)
saleor/graphql/meta/schema.py 100.00% <0.00%> (ø)
saleor/graphql/meta/mutations.py 93.93% <0.00%> (ø)
saleor/graphql/meta/deprecated/mutations.py 89.61% <0.00%> (ø)
saleor/graphql/meta/permissions.py 87.50% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c063595...67a46a3. Read the comment docs.

Copy link

django-queries commented Jan 20, 2020

Here is the report for 67a46a3 (mirumee/saleor @ 5028/Unify_meta_mutations)
Base comparison is c063595.

No differences were found. (click me)

# api.benchmark checkout
  test name                                  	left count 	right count	duplicate count
  -------------------------------------------	-----------	-----------	---------------
  add billing address to checkout            	         34	         34	             20
  add shipping to checkout                   	          7	          7	              0
  checkout payment charge                    	         10	         10	              0
  complete checkout                          	          8	          8	              0
  create checkout                            	          5	          5	              1

# api.benchmark homepage
  test name                                  	left count 	right count	duplicate count
  -------------------------------------------	-----------	-----------	---------------
  retrieve main menu                         	          5	          5	              0
  retrieve product list                      	          4	          4	              0
  retrieve secondary menu                    	          5	          5	              0
  retrieve shop                              	          2	          2	              0

# api.benchmark product
  test name                                  	left count 	right count	duplicate count
  -------------------------------------------	-----------	-----------	---------------
  product details                            	         17	         17	              3
  retrieve product attributes                	          9	          9	              0

# api.benchmark variant
  test name                                  	left count 	right count	duplicate count
  -------------------------------------------	-----------	-----------	---------------
  product variant bulk create                	         51	         51	              3
  retrieve variant list                      	         23	         23	              9

# api product sorting attributes
  test name                                  	left count 	right count	duplicate count
  -------------------------------------------	-----------	-----------	---------------
  sort product not having attribute data     	         21	         21	              0

saleor/graphql/meta/mutations.py Outdated Show resolved Hide resolved
saleor/graphql/meta/mutations.py Outdated Show resolved Hide resolved
saleor/graphql/meta/mutations.py Outdated Show resolved Hide resolved
@fowczarek fowczarek force-pushed the 5028/Unify_meta_mutations branch 2 times, most recently from 23ab6ea to ec3ec69 Compare January 31, 2020 13:30
@fowczarek fowczarek force-pushed the 5028/Unify_meta_mutations branch 2 times, most recently from 5e7ef54 to b993606 Compare February 7, 2020 13:50
@lgtm-com
Copy link

lgtm-com bot commented Feb 7, 2020

This pull request introduces 2 alerts and fixes 1 when merging b993606 into b0810a5 - view on LGTM.com

new alerts:

  • 2 for Module-level cyclic import

fixed alerts:

  • 1 for Module imports itself

@fowczarek fowczarek force-pushed the 5028/Unify_meta_mutations branch 2 times, most recently from c2df224 to 10c82d3 Compare February 10, 2020 09:38
@lgtm-com
Copy link

lgtm-com bot commented Feb 10, 2020

This pull request fixes 1 alert when merging 10c82d3 into b0810a5 - view on LGTM.com

fixed alerts:

  • 1 for Module imports itself

@lgtm-com
Copy link

lgtm-com bot commented Feb 10, 2020

This pull request fixes 1 alert when merging 35a612e into 8109634 - view on LGTM.com

fixed alerts:

  • 1 for Module imports itself

@lgtm-com
Copy link

lgtm-com bot commented Feb 11, 2020

This pull request fixes 1 alert when merging 9c7352b into 00284d0 - view on LGTM.com

fixed alerts:

  • 1 for Module imports itself

@lgtm-com
Copy link

lgtm-com bot commented Feb 11, 2020

This pull request fixes 1 alert when merging 28ead36 into 00284d0 - view on LGTM.com

fixed alerts:

  • 1 for Module imports itself

saleor/graphql/schema.graphql Outdated Show resolved Hide resolved
saleor/graphql/schema.graphql Outdated Show resolved Hide resolved
saleor/graphql/schema.graphql Outdated Show resolved Hide resolved
saleor/graphql/schema.graphql Outdated Show resolved Hide resolved
saleor/checkout/models.py Outdated Show resolved Hide resolved
saleor/core/error_codes.py Outdated Show resolved Hide resolved
saleor/checkout/utils.py Outdated Show resolved Hide resolved
saleor/graphql/account/mutations/account.py Outdated Show resolved Hide resolved
saleor/graphql/checkout/types.py Show resolved Hide resolved
@lgtm-com
Copy link

lgtm-com bot commented Feb 14, 2020

This pull request fixes 1 alert when merging fae262d into 73f40eb - view on LGTM.com

fixed alerts:

  • 1 for Module imports itself

@lgtm-com
Copy link

lgtm-com bot commented Feb 14, 2020

This pull request fixes 1 alert when merging c9dac4c into 9591496 - view on LGTM.com

fixed alerts:

  • 1 for Module imports itself

@lgtm-com
Copy link

lgtm-com bot commented Feb 17, 2020

This pull request fixes 1 alert when merging 05b0fa753b295dc846ce5fa8abcd3e9af2a13436 into 9591496 - view on LGTM.com

fixed alerts:

  • 1 for Module imports itself

@lgtm-com
Copy link

lgtm-com bot commented Feb 17, 2020

This pull request fixes 1 alert when merging 0f470cf into 9591496 - view on LGTM.com

fixed alerts:

  • 1 for Module imports itself

@lgtm-com
Copy link

lgtm-com bot commented Feb 21, 2020

This pull request fixes 1 alert when merging 67a46a3 into c063595 - view on LGTM.com

fixed alerts:

  • 1 for Module imports itself

@maarcingebala maarcingebala merged commit 8a01591 into master Feb 21, 2020
@maarcingebala maarcingebala deleted the 5028/Unify_meta_mutations branch February 21, 2020 13:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unify meta mutations
5 participants