Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update permission groups #5513

Merged
merged 147 commits into from
Apr 22, 2020
Merged

Update permission groups #5513

merged 147 commits into from
Apr 22, 2020

Conversation

IKarbowiak
Copy link
Member

@IKarbowiak IKarbowiak commented Apr 21, 2020

Add all missing functionalities for permission groups.

Impact

  • New migrations
  • New/Updated API fields or mutations
  • Deprecated API fields or mutations
  • Removed API types, fields, or mutations

Pull Request Checklist

  • Privileged queries and mutations are guarded by proper permission checks
  • Database queries are optimized and the number of queries is constant
  • Database migration files are up to date
  • The changes are tested
  • GraphQL schema and type definitions are up to date
  • Changes are mentioned in the changelog

IKarbowiak and others added 30 commits March 13, 2020 10:58
…restriction

Update create permission group restriction
…om:mirumee/saleor into allow-specifying-users-in-groups-mutations
@codecov
Copy link

codecov bot commented Apr 21, 2020

Codecov Report

Merging #5513 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #5513   +/-   ##
=======================================
  Coverage   91.54%   91.54%           
=======================================
  Files         283      283           
  Lines       18821    18821           
  Branches     1713     1713           
=======================================
  Hits        17230    17230           
  Misses       1168     1168           
  Partials      423      423           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d6e3c25...d6e3c25. Read the comment docs.

@db-queries
Copy link

db-queries bot commented Apr 21, 2020

Here is the report for d6e3c25 (mirumee/saleor @ feature/permission-groups)
Base comparison is 909ee34.

**Found 23 differences!** (click me)

# api.benchmark account
  test name                                                  	left count 	right count	duplicate count
  -----------------------------------------------------------	-----------	-----------	---------------
+ delete staff members                                       	          -	         32	              1
+ query staff user                                           	          -	         20	              4
+ staff create                                               	          -	         24	              5
+ staff update groups and permissions                        	          -	         36	              6

# api.benchmark category
  test name                                                  	left count 	right count	duplicate count
  -----------------------------------------------------------	-----------	-----------	---------------
  category view                                              	         24	         24	              0

# api.benchmark checkout mutations
  test name                                                  	left count 	right count	duplicate count
  -----------------------------------------------------------	-----------	-----------	---------------
- add billing address to checkout                            	         56	         58	             34
- add shipping to checkout                                   	         34	         36	             12
- checkout email update                                      	         33	         35	             21
  checkout payment charge                                    	         23	         23	              5
- checkout shipping address update                           	         30	         32	              8
- checkout voucher code                                      	         65	         67	             42
- complete checkout                                          	         72	         75	             19
- create checkout                                            	        154	        184	            114
- update checkout lines                                      	        103	        133	             77

# api.benchmark collection
  test name                                                  	left count 	right count	duplicate count
  -----------------------------------------------------------	-----------	-----------	---------------
  collection view                                            	         22	         22	              0

# api.benchmark homepage
  test name                                                  	left count 	right count	duplicate count
  -----------------------------------------------------------	-----------	-----------	---------------
  featured products list                                     	         21	         21	              0
  retrieve main menu                                         	          8	          8	              0
  retrieve product list                                      	          6	          6	              0
  retrieve secondary menu                                    	          8	          8	              0
  retrieve shop                                              	          2	          2	              0
- user checkout details                                      	         54	         56	             34

# api.benchmark order
  test name                                                  	left count 	right count	duplicate count
  -----------------------------------------------------------	-----------	-----------	---------------
  user order details                                         	         18	         18	              4

# api.benchmark permission group
  test name                                                  	left count 	right count	duplicate count
  -----------------------------------------------------------	-----------	-----------	---------------
+ permission group create                                    	          -	         23	              5
+ permission group delete                                    	          -	         21	              4
+ permission group query                                     	          -	          9	              0
+ permission group update                                    	          -	         35	              5
+ permission group update remove users with manage staff     	          -	         31	              4

# api.benchmark product
  test name                                                  	left count 	right count	duplicate count
  -----------------------------------------------------------	-----------	-----------	---------------
- product details                                            	         18	         22	              5
  retrieve product attributes                                	          9	          9	              0

# api.benchmark variant
  test name                                                  	left count 	right count	duplicate count
  -----------------------------------------------------------	-----------	-----------	---------------
  product variant bulk create                                	         48	         48	              3
- retrieve variant list                                      	         24	         36	             15

# api.benchmark variant stocks
  test name                                                  	left count 	right count	duplicate count
  -----------------------------------------------------------	-----------	-----------	---------------
- product variants stocks create                             	         19	         21	              4
- product variants stocks delete                             	         16	         19	              4
- product variants stocks update                             	         23	         25	              4

# api product sorting attributes
  test name                                                  	left count 	right count	duplicate count
  -----------------------------------------------------------	-----------	-----------	---------------
  sort product not having attribute data                     	         20	         20	              0

@IKarbowiak IKarbowiak self-assigned this Apr 21, 2020
@lgtm-com
Copy link

lgtm-com bot commented Apr 21, 2020

This pull request introduces 1 alert when merging 597a839 into 909ee34 - view on LGTM.com

new alerts:

  • 1 for First parameter of a method is not named 'self'

CHANGELOG.md Outdated Show resolved Hide resolved
saleor/account/error_codes.py Outdated Show resolved Hide resolved
@lgtm-com
Copy link

lgtm-com bot commented Apr 22, 2020

This pull request introduces 1 alert when merging 61a897f into 3284a2f - view on LGTM.com

new alerts:

  • 1 for First parameter of a method is not named 'self'

@lgtm-com
Copy link

lgtm-com bot commented Apr 22, 2020

This pull request introduces 1 alert when merging d6e3c25 into 3284a2f - view on LGTM.com

new alerts:

  • 1 for First parameter of a method is not named 'self'

@maarcingebala maarcingebala merged commit 9863ea3 into master Apr 22, 2020
@maarcingebala maarcingebala deleted the feature/permission-groups branch April 22, 2020 10:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants