Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing OrderEvents in checkout flow #5684

Merged
merged 7 commits into from
Jun 18, 2020

Conversation

koradon
Copy link
Contributor

@koradon koradon commented May 22, 2020

I want to merge this change because...
it adds missing OrderEvents in checkout flow.

fixes #5535

Impact

  • New migrations
  • New/Updated API fields or mutations
  • Deprecated API fields or mutations
  • Removed API types, fields, or mutations

Pull Request Checklist

  • Privileged queries and mutations are guarded by proper permission checks
  • Database queries are optimized and the number of queries is constant
  • Database migration files are up to date
  • The changes are tested
  • GraphQL schema and type definitions are up to date
  • Changes are mentioned in the changelog

@koradon koradon self-assigned this May 22, 2020
@db-queries
Copy link

db-queries bot commented May 22, 2020

Here is the report for 8b3c6fb (mirumee/saleor @ fix/missing_checkout_events)
Base comparison is 3ef007e.

**Found 1 differences!** (click me)

# saleor.graphql.accountbenchmark account
  test name                                                  	left count 	right count	duplicate count
  -----------------------------------------------------------	-----------	-----------	---------------
  delete staff members                                       	         32	         32	              0
  query staff user                                           	         21	         21	              4
  staff create                                               	         24	         24	              5
  staff update groups and permissions                        	         36	         36	              6

# saleor.graphql.accountbenchmark permission group
  test name                                                  	left count 	right count	duplicate count
  -----------------------------------------------------------	-----------	-----------	---------------
  permission group create                                    	         21	         21	              3
  permission group delete                                    	         22	         22	              4
  permission group query                                     	          8	          8	              0
  permission group update                                    	         36	         36	              2
  permission group update remove users with manage staff     	         31	         31	              4

# saleor.graphql.checkoutbenchmark checkout mutations
  test name                                                  	left count 	right count	duplicate count
  -----------------------------------------------------------	-----------	-----------	---------------
  add billing address to checkout                            	         50	         50	             26
  add shipping to checkout                                   	         37	         37	             11
  checkout email update                                      	         28	         28	             13
  checkout payment charge                                    	         27	         27	              6
  checkout shipping address update                           	         33	         33	              8
  checkout voucher code                                      	         57	         57	             31
- complete checkout                                          	         73	         81	             22
  create checkout                                            	        130	        130	             65
  update checkout lines                                      	         97	         97	             44

# saleor.graphql.checkoutbenchmark homepage
  test name                                                  	left count 	right count	duplicate count
  -----------------------------------------------------------	-----------	-----------	---------------
  user checkout details                                      	         50	         50	             26

# saleor.graphql.menubenchmark homepage
  test name                                                  	left count 	right count	duplicate count
  -----------------------------------------------------------	-----------	-----------	---------------
  retrieve main menu                                         	          5	          5	              0
  retrieve secondary menu                                    	          5	          5	              0

# saleor.graphql.orderbenchmark order
  test name                                                  	left count 	right count	duplicate count
  -----------------------------------------------------------	-----------	-----------	---------------
  user order details                                         	         17	         17	              2

# saleor.graphql.productbenchmark category
  test name                                                  	left count 	right count	duplicate count
  -----------------------------------------------------------	-----------	-----------	---------------
  category view                                              	         18	         18	              1

# saleor.graphql.productbenchmark collection
  test name                                                  	left count 	right count	duplicate count
  -----------------------------------------------------------	-----------	-----------	---------------
  collection view                                            	         17	         17	              0

# saleor.graphql.productbenchmark homepage
  test name                                                  	left count 	right count	duplicate count
  -----------------------------------------------------------	-----------	-----------	---------------
  featured products list                                     	         14	         14	              0
  retrieve product list                                      	          5	          5	              0

# saleor.graphql.productbenchmark product
  test name                                                  	left count 	right count	duplicate count
  -----------------------------------------------------------	-----------	-----------	---------------
  product details                                            	         16	         16	              0
  retrieve product attributes                                	          7	          7	              0

# saleor.graphql.productbenchmark variant
  test name                                                  	left count 	right count	duplicate count
  -----------------------------------------------------------	-----------	-----------	---------------
  product variant bulk create                                	         48	         48	              2
  retrieve variant list                                      	         18	         18	              2

# saleor.graphql.productbenchmark variant stocks
  test name                                                  	left count 	right count	duplicate count
  -----------------------------------------------------------	-----------	-----------	---------------
  product variants stocks create                             	         23	         23	              5
  product variants stocks delete                             	         20	         20	              5
  product variants stocks update                             	         28	         28	              5

# saleor.graphql.producttest product sorting attributes
  test name                                                  	left count 	right count	duplicate count
  -----------------------------------------------------------	-----------	-----------	---------------
  sort product not having attribute data                     	         20	         20	              0

# saleor.graphql.shopbenchmark homepage
  test name                                                  	left count 	right count	duplicate count
  -----------------------------------------------------------	-----------	-----------	---------------
  retrieve shop                                              	          2	          2	              0

@koradon koradon force-pushed the fix/missing_checkout_events branch from 9f85153 to 5000cf1 Compare May 22, 2020 11:41
@koradon koradon requested a review from a team May 22, 2020 12:32
saleor/order/actions.py Outdated Show resolved Hide resolved
saleor/order/actions.py Show resolved Hide resolved
saleor/order/actions.py Outdated Show resolved Hide resolved
@koradon koradon force-pushed the fix/missing_checkout_events branch from 5000cf1 to a93c4d1 Compare June 12, 2020 06:13
@codecov
Copy link

codecov bot commented Jun 12, 2020

Codecov Report

Merging #5684 into master will increase coverage by 0.00%.
The diff coverage is 92.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #5684   +/-   ##
=======================================
  Coverage   91.88%   91.89%           
=======================================
  Files         322      322           
  Lines       20120    20123    +3     
  Branches     1853     1858    +5     
=======================================
+ Hits        18488    18492    +4     
+ Misses       1198     1196    -2     
- Partials      434      435    +1     
Impacted Files Coverage Δ
saleor/payment/utils.py 91.52% <ø> (-0.28%) ⬇️
saleor/graphql/order/mutations/orders.py 96.29% <50.00%> (-0.36%) ⬇️
saleor/order/actions.py 94.77% <92.30%> (-0.30%) ⬇️
saleor/order/events.py 78.09% <100.00%> (+3.34%) ⬆️
saleor/order/models.py 86.56% <100.00%> (+0.47%) ⬆️
saleor/graphql/core/utils/__init__.py 100.00% <0.00%> (ø)
saleor/graphql/warehouse/mutations.py 100.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6a02be8...f1660a0. Read the comment docs.

@koradon koradon force-pushed the fix/missing_checkout_events branch from d22cb97 to cd0c06c Compare June 18, 2020 08:02
@maarcingebala maarcingebala merged commit 4991586 into master Jun 18, 2020
@maarcingebala maarcingebala deleted the fix/missing_checkout_events branch June 18, 2020 10:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Missing payment_captured and order_fully_paid events
3 participants