Drop country middleware #6784
Merged
Drop country middleware #6784
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request introduces 2 alerts and fixes 1 when merging 1b7d4ad into d32d5bf - view on LGTM.com new alerts:
fixed alerts:
|
|
This pull request introduces 2 alerts and fixes 1 when merging db99438 into 50eff94 - view on LGTM.com new alerts:
fixed alerts:
|
|
Here is the report for dc77bec (mirumee:4315-drop-context-country) Found 6 differences! (click me)
# saleor.graphql.accountbenchmark account
test name left count right count duplicate count
----------------------------------------------------------- ----------- ----------- ---------------
delete staff members 32 32 0
query staff user 20 20 4
staff create 22 22 4
staff update groups and permissions 33 33 5
# saleor.graphql.accountbenchmark permission group
test name left count right count duplicate count
----------------------------------------------------------- ----------- ----------- ---------------
permission group create 19 19 2
permission group delete 20 20 3
permission group query 7 7 0
permission group update 33 33 1
permission group update remove users with manage staff 27 27 3
# saleor.graphql.attributebenchmark attribute
test name left count right count duplicate count
----------------------------------------------------------- ----------- ----------- ---------------
query attribute 7 7 2
query attributes 11 11 3
# saleor.graphql.checkoutbenchmark checkout mutations
test name left count right count duplicate count
----------------------------------------------------------- ----------- ----------- ---------------
add billing address to checkout 53 53 8
add shipping to checkout 64 64 12
checkout email update 26 26 3
checkout payment charge 34 34 11
checkout shipping address update 64 64 13
checkout voucher code 64 64 10
complete checkout 109 109 20
create checkout 79 79 16
customer complete checkout 146 146 34
- update checkout lines 91 93 24
# saleor.graphql.checkoutbenchmark homepage
test name left count right count duplicate count
----------------------------------------------------------- ----------- ----------- ---------------
user checkout details 39 39 2
# saleor.graphql.discountbenchmark sales
test name left count right count duplicate count
----------------------------------------------------------- ----------- ----------- ---------------
sales query with channel slug 16 16 0
sales query withot channel slug 15 15 0
# saleor.graphql.discountbenchmark vouchers
test name left count right count duplicate count
----------------------------------------------------------- ----------- ----------- ---------------
vouchers query with channel slug 16 16 0
vouchers query withot channel slug 15 15 0
# saleor.graphql.menubenchmark homepage
test name left count right count duplicate count
----------------------------------------------------------- ----------- ----------- ---------------
retrieve main menu 5 5 0
retrieve secondary menu 5 5 0
# saleor.graphql.orderbenchmark order
test name left count right count duplicate count
----------------------------------------------------------- ----------- ----------- ---------------
- user order details 20 22 1
# saleor.graphql.pagebenchmark page type
test name left count right count duplicate count
----------------------------------------------------------- ----------- ----------- ---------------
query page type 17 17 5
query page types 19 19 5
# saleor.graphql.productbenchmark category
test name left count right count duplicate count
----------------------------------------------------------- ----------- ----------- ---------------
- category view 22 24 1
# saleor.graphql.productbenchmark collection
test name left count right count duplicate count
----------------------------------------------------------- ----------- ----------- ---------------
collection view 6 6 0
retrieve collection channel listings 4 4 0
# saleor.graphql.productbenchmark homepage
test name left count right count duplicate count
----------------------------------------------------------- ----------- ----------- ---------------
report product sales 10 10 3
retrieve product list 4 4 0
# saleor.graphql.productbenchmark product
test name left count right count duplicate count
----------------------------------------------------------- ----------- ----------- ---------------
- product details 24 26 0
- retrieve channel listings 16 18 0
retrieve product attributes 8 8 0
retrive products with product types and attributes 6 6 0
# saleor.graphql.productbenchmark variant
test name left count right count duplicate count
----------------------------------------------------------- ----------- ----------- ---------------
product variant bulk create 59 59 2
- retrieve variant list 22 24 0
# saleor.graphql.productbenchmark variant stocks
test name left count right count duplicate count
----------------------------------------------------------- ----------- ----------- ---------------
product variants stocks create 22 22 5
product variants stocks delete 19 19 5
product variants stocks update 27 27 5
# saleor.graphql.producttest product sorting attributes
test name left count right count duplicate count
----------------------------------------------------------- ----------- ----------- ---------------
sort product not having attribute data 23 23 0
# saleor.graphql.shippingbenchmark shipping methods
test name left count right count duplicate count
----------------------------------------------------------- ----------- ----------- ---------------
vouchers query with channel slug 10 10 0
vouchers query without channel slug 9 9 0
# saleor.graphql.shopbenchmark homepage
test name left count right count duplicate count
----------------------------------------------------------- ----------- ----------- ---------------
retrieve shop 2 2 0
|
Codecov Report
@@ Coverage Diff @@
## master #6784 +/- ##
==========================================
+ Coverage 92.91% 92.94% +0.02%
==========================================
Files 395 395
Lines 27922 27904 -18
Branches 2912 2908 -4
==========================================
- Hits 25945 25934 -11
+ Misses 1381 1379 -2
+ Partials 596 591 -5
Continue to review full report at Codecov.
|
|
This pull request introduces 2 alerts and fixes 1 when merging c22bf69 into 50eff94 - view on LGTM.com new alerts:
fixed alerts:
|
|
This pull request fixes 1 alert when merging c4fea16 into 50eff94 - view on LGTM.com fixed alerts:
|
fowczarek
approved these changes
Jan 27, 2021
IKarbowiak
approved these changes
Jan 27, 2021
fowczarek
approved these changes
Jan 27, 2021
fowczarek
approved these changes
Jan 27, 2021
korycins
approved these changes
Jan 27, 2021
|
This pull request fixes 1 alert when merging bb4efe1 into 50eff94 - view on LGTM.com fixed alerts:
|
|
PR is currently blocked by storefront/SDK which currently uses the |
|
This pull request fixes 1 alert when merging 18cbcae into fbfc66e - view on LGTM.com fixed alerts:
|
patrys
approved these changes
Jan 28, 2021
fowczarek
approved these changes
Feb 1, 2021
|
This pull request fixes 1 alert when merging a1ce14a into 05efc53 - view on LGTM.com fixed alerts:
|
|
This pull request fixes 1 alert when merging 2036251 into 97071ce - view on LGTM.com fixed alerts:
|
maarcingebala
added
the
approved-breaking-change
|
This pull request fixes 1 alert when merging d69c5c7 into 9b668be - view on LGTM.com fixed alerts:
|
fowczarek
approved these changes
Feb 3, 2021
maarcingebala
added
approved-breaking-change
fowczarek
approved these changes
Feb 10, 2021
|
This pull request fixes 1 alert when merging dc77bec into 8a33bfb - view on LGTM.com fixed alerts:
|
11 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR drops the country middleware (
saleor.core.middleware.country), which was using GeoIP to determine the user's country. In the new approach, user location is provided as an argument in queries or mutations that need it for tax or stock calculations.Note: this PR removes
CheckoutPaymentCreate.billingAddressinput field which is a breaking change. The idea is that we should always use billing address from the checkout instance, to have one way of providing billing addresses for payments. This field will be marked as deprecated in Saleor 2.11.Fixes #4315
Todo:
CheckoutPaymentCreate.billingAddressinput on 2.11Impact
Pull Request Checklist