Add product variants events #6963
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Here is the report for 9578783 (piotrgrundas:product_variant_events) Found 1 differences! (click me)
# saleor.graphql.accountbenchmark account
test name left count right count duplicate count
----------------------------------------------------------- ----------- ----------- ---------------
delete staff members 32 32 0
query staff user 19 19 4
staff create 22 22 4
staff update groups and permissions 33 33 5
# saleor.graphql.accountbenchmark permission group
test name left count right count duplicate count
----------------------------------------------------------- ----------- ----------- ---------------
permission group create 19 19 2
permission group delete 20 20 3
permission group query 7 7 0
permission group update 33 33 1
permission group update remove users with manage staff 27 27 3
# saleor.graphql.attributebenchmark attribute
test name left count right count duplicate count
----------------------------------------------------------- ----------- ----------- ---------------
query attribute 7 7 2
query attributes 11 11 3
# saleor.graphql.checkoutbenchmark checkout mutations
test name left count right count duplicate count
----------------------------------------------------------- ----------- ----------- ---------------
add billing address to checkout 49 49 5
add shipping to checkout 64 64 10
checkout email update 23 23 0
checkout payment charge 41 41 16
checkout shipping address update 69 69 14
checkout voucher code 68 68 11
complete checkout 96 96 21
create checkout 76 76 12
customer complete checkout 133 133 35
update checkout lines 87 87 16
# saleor.graphql.checkoutbenchmark homepage
test name left count right count duplicate count
----------------------------------------------------------- ----------- ----------- ---------------
user checkout details 39 39 2
# saleor.graphql.discountbenchmark sales
test name left count right count duplicate count
----------------------------------------------------------- ----------- ----------- ---------------
sales query with channel slug 16 16 0
sales query withot channel slug 15 15 0
# saleor.graphql.discountbenchmark vouchers
test name left count right count duplicate count
----------------------------------------------------------- ----------- ----------- ---------------
vouchers query with channel slug 16 16 0
vouchers query withot channel slug 15 15 0
# saleor.graphql.menubenchmark homepage
test name left count right count duplicate count
----------------------------------------------------------- ----------- ----------- ---------------
retrieve main menu 5 5 0
retrieve secondary menu 5 5 0
# saleor.graphql.orderbenchmark fulfillment refund and return products
test name left count right count duplicate count
----------------------------------------------------------- ----------- ----------- ---------------
fulfillment refund products order lines 46 46 2
fulfillment return products order lines 99 99 11
# saleor.graphql.orderbenchmark order
test name left count right count duplicate count
----------------------------------------------------------- ----------- ----------- ---------------
staff order details 69 69 41
user order details 23 23 1
# saleor.graphql.pagebenchmark page type
test name left count right count duplicate count
----------------------------------------------------------- ----------- ----------- ---------------
query page type 17 17 5
query page types 19 19 5
# saleor.graphql.productbenchmark category
test name left count right count duplicate count
----------------------------------------------------------- ----------- ----------- ---------------
category view 24 24 1
# saleor.graphql.productbenchmark collection
test name left count right count duplicate count
----------------------------------------------------------- ----------- ----------- ---------------
collection view 6 6 0
retrieve collection channel listings 4 4 0
# saleor.graphql.productbenchmark homepage
test name left count right count duplicate count
----------------------------------------------------------- ----------- ----------- ---------------
report product sales 10 10 3
retrieve product list 4 4 0
# saleor.graphql.productbenchmark product
test name left count right count duplicate count
----------------------------------------------------------- ----------- ----------- ---------------
product details 26 26 0
retrieve channel listings 18 18 0
retrieve product attributes 8 8 0
retrive products with product types and attributes 6 6 0
# saleor.graphql.productbenchmark variant
test name left count right count duplicate count
----------------------------------------------------------- ----------- ----------- ---------------
- product variant bulk create 59 62 2
retrieve variant list 24 24 0
# saleor.graphql.productbenchmark variant stocks
test name left count right count duplicate count
----------------------------------------------------------- ----------- ----------- ---------------
product variants stocks create 22 22 5
product variants stocks delete 19 19 5
product variants stocks update 27 27 5
# saleor.graphql.producttest product sorting attributes
test name left count right count duplicate count
----------------------------------------------------------- ----------- ----------- ---------------
sort product not having attribute data 23 23 0
# saleor.graphql.shippingbenchmark shipping methods
test name left count right count duplicate count
----------------------------------------------------------- ----------- ----------- ---------------
vouchers query with channel slug 10 10 0
vouchers query without channel slug 9 9 0
# saleor.graphql.shopbenchmark homepage
test name left count right count duplicate count
----------------------------------------------------------- ----------- ----------- ---------------
retrieve shop 2 2 0
|
Codecov Report
@@ Coverage Diff @@
## master #6963 +/- ##
==========================================
- Coverage 93.01% 93.00% -0.01%
==========================================
Files 423 423
Lines 31146 31227 +81
Branches 3165 3178 +13
==========================================
+ Hits 28969 29044 +75
- Misses 1532 1534 +2
- Partials 645 649 +4
Continue to review full report at Codecov.
|
piotrgrundas
force-pushed
the
product_variant_events
branch
from
d1b19ec
to
30a1c3a
Compare
|
This pull request introduces 1 alert when merging 30a1c3aa3dfe402f5362bf2caa85d63ed815e834 into 326a5b8 - view on LGTM.com new alerts:
|
piotrgrundas
force-pushed
the
product_variant_events
branch
from
30a1c3a
to
d1b3d13
Compare
piotrgrundas
force-pushed
the
product_variant_events
branch
from
d1b3d13
to
9208c3f
Compare
piotrgrundas
force-pushed
the
product_variant_events
branch
4 times, most recently
from
654b444
to
000c870
Compare
piotrgrundas
force-pushed
the
product_variant_events
branch
2 times, most recently
from
297d962
to
ccc2b4d
Compare
piotrgrundas
force-pushed
the
product_variant_events
branch
from
ccc2b4d
to
5beb808
Compare
piotrgrundas
commented
Mar 10, 2021
| @@ -219,7 +224,6 @@ def generate_customer_payload(customer: "User"): | |||
| "name", | |||
| "description", | |||
| "currency", | |||
| "attributes", | |||
There was a problem hiding this comment.
It did not work 🤫
korycins
reviewed
Mar 11, 2021
IKarbowiak
reviewed
Mar 11, 2021
fowczarek
requested changes
Mar 11, 2021
There was a problem hiding this comment.
We have a few more mutations to update ProductVariant:
- ProductVariantStocksCreate
- ProductVariantStocksDelete
- ProductVariantStocksUpdate
- ProductVariantTranslate
- ProductVariantChannelListingUpdate
- ProductVariantReorderAttributeValues
- VariantImageAssign
- VariantImageUnassign
I'm not sure that we should trigger webhook in all the above mutations but for sure we should trigger webhook in ProductVariantChannelListingUpdate
fowczarek
reviewed
Mar 11, 2021
|
This pull request introduces 2 alerts when merging db57dfd into 3f6f224 - view on LGTM.com new alerts:
|
piotrgrundas
force-pushed
the
product_variant_events
branch
2 times, most recently
from
5436f1f
to
b07075c
Compare
piotrgrundas
force-pushed
the
product_variant_events
branch
from
b07075c
to
feb2a73
Compare
korycins
reviewed
Mar 12, 2021
IKarbowiak
reviewed
Mar 12, 2021
piotrgrundas
force-pushed
the
product_variant_events
branch
5 times, most recently
from
3ae9bbe
to
0e8c05e
Compare
korycins
reviewed
Mar 12, 2021
piotrgrundas
force-pushed
the
product_variant_events
branch
from
0e8c05e
to
be709d3
Compare
korycins
reviewed
Mar 15, 2021
korycins
approved these changes
Mar 15, 2021
IKarbowiak
approved these changes
Mar 15, 2021
fowczarek
approved these changes
Mar 16, 2021
maarcingebala
approved these changes
Mar 16, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I want to merge this change because I need events for product variant:
Dashboard PR
Impact
Pull Request Checklist