Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix #166 [Legacy] cannot open rename modules in php 8 #167

Closed
wants to merge 3 commits into from
Closed

Fix #166 [Legacy] cannot open rename modules in php 8 #167

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
dbe98f9
Fix #166 [Legacy] cannot open rename modules in php 8
abuzarfaris Oct 14, 2022
7c307cb
Fix saving of renaming modules as well
abuzarfaris Oct 15, 2022
a56f696
Remove issue number
abuzarfaris Oct 19, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions public/legacy/modules/Studio/wizards/RenameModules.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -336,7 +336,7 @@ protected function display()
$buttons[] = array('text'=>$mod_strings['LBL_BTN_UNDO'],'actionScript'=>"onclick='jstransaction.undo()'" );
$buttons[] = array('text'=>$mod_strings['LBL_BTN_REDO'],'actionScript'=>"onclick='jstransaction.redo()'" );
$buttons[] = array('text'=>$mod_strings['LBL_BTN_SAVE'],'actionScript'=>"onclick='if(check_form(\"editdropdown\")){document.editdropdown.submit();}'");
$buttonTxt = StudioParser::buildImageButtons($buttons);
$buttonTxt = (new StudioParser)->buildImageButtons($buttons);
$smarty->assign('buttons', $buttonTxt);
$smarty->assign('dropdown_lang', $selected_lang);

Expand Down Expand Up @@ -805,14 +805,14 @@ private function changeAppStringEntries()
{
$GLOBALS['log']->debug('Begining to save app string entries');
//Save changes to the moduleList app string entry
DropDownHelper::saveDropDown($_REQUEST);
(new DropDownHelper)->saveDropDown($_REQUEST);

//Save changes to the moduleListSingular app string entry
$newParams = array();
$newParams['dropdown_name'] = 'moduleListSingular';
$newParams['dropdown_lang'] = isset($_REQUEST['dropdown_lang']) ? $_REQUEST['dropdown_lang'] : '';
$newParams['use_push'] = true;
DropDownHelper::saveDropDown($this->createModuleListSingularPackage($newParams, $this->changedModules));
(new DropDownHelper)->saveDropDown($this->createModuleListSingularPackage($newParams, $this->changedModules));

//Save changes to the "*type_display*" app_list_strings entry.
global $app_list_strings;
Expand All @@ -823,7 +823,7 @@ private function changeAppStringEntries()
foreach ($typeDisplayList as $typeDisplay) {
if (isset($app_list_strings[$typeDisplay]) && isset($app_list_strings[$typeDisplay][$moduleName])) {
$newParams['dropdown_name'] = $typeDisplay;
DropDownHelper::saveDropDown($this->createModuleListSingularPackage($newParams, array($moduleName => $this->changedModules[$moduleName])));
(new DropDownHelper)->saveDropDown($this->createModuleListSingularPackage($newParams, array($moduleName => $this->changedModules[$moduleName])));
}
}
}
Expand Down