Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #323 - Dynamic dropdown #382

Closed

Conversation

yunusyerli1
Copy link
Contributor

Description

Make dropdown fields dynamic#323

Motivation and Context

The status field in the Cases module is showing all values no matter what value is selected in the State field.

How To Test This

In base-field.manifest.ts file change following:
From :
'enum.detail': EnumDetailFieldComponent,
'enum.edit': EnumEditFieldComponent,
To:
'enum.detail': DropdownEnumDetailFieldComponent,
'enum.edit': DropdownEnumEditFieldComponent,
In editview, select State and check Status field. You ll see all values.
Select another value in State, and still you will see all the values

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Final checklist

  • My code follows the code style of this project found here.
  • My change requires a change to the documentation.
  • I have read the How to Contribute guidelines.

@serhiisamko091184 serhiisamko091184 added Status:Assessed PRs that have been tested and confirmed to resolve an issue by a core team member Status: Requires Code Review Area: Frontend labels Nov 8, 2023
@serhiisamko091184
Copy link
Contributor

Hey @yunusyerli1,
thanks a lot for current contribution!

Regards,
Serhii

@clemente-raposo clemente-raposo added the Status:Requires Updates Issues & PRs which requires input or update from the author label Dec 7, 2023
@chris001 chris001 mentioned this pull request Jan 31, 2024
@lukio
Copy link
Contributor

lukio commented Feb 2, 2024

This PR fixes Make dropdown fields dynamic #323.
Also, this PR is need it by PR #400 to works.

@johnM2401
Copy link

Hey @yunusyerli1!
Thank you for your PR!

We weren't able to bring in your PR as we made several changes to the enum, multienum and relate fields for edit and filter modes which required us to do extra changes additional to the ones you suggested

However, this PR and your contributions are still greatly appreciated.

I will close this off as the issue has been resolved by the changes to enum-type fields in the latest release. (8.6.0)

@johnM2401 johnM2401 closed this Apr 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: Frontend Status:Assessed PRs that have been tested and confirmed to resolve an issue by a core team member Status: Requires Code Review Status:Requires Updates Issues & PRs which requires input or update from the author
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants