Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature date components change proposal #400

Open
wants to merge 2 commits into
base: hotfix
Choose a base branch
from

Conversation

mpuyosa91
Copy link
Contributor

In the process of solving #399 and understanding the Date component in edit mode and filter mode, to improve the readability and functionality this proposal was created.

Description

  • The real fix was on core/app/core/src/lib/fields/base/base-field.component.ts:257 of fix Status field is dependent on state field but it not responding to changes #323, but I do not want to leave this change proposal uncommitted.
  • core/app/core/src/lib/fields/date/templates/edit/date.component.ts:[64~75, 97~124]: three new functions were created to centralise value assignation
  • core/app/core/src/lib/fields/date/templates/filter/date.component.ts:[67~74, 101~127]: four new functions were created to centralise value assignation.
  • core/app/core/src/lib/fields/date/templates/edit/date.component.html:[35~36] and core/app/core/src/lib/fields/date/templates/filter/date.component.html:[35~36] we do not need to react to ngModelChange of the component to update this.field.value and this.dateModel, that is done through this.field.formControl changes that triggers setFieldValue function.

Motivation and Context

I do not want to leave this change proposal uncommitted.

How To Test This

  1. Open Opportunities in ListView
  2. Click the Filter button to open the Filter
  3. Check the Expected Close Date field and try to filter by.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Final checklist

  • My code follows the code style of this project found here.
  • My change requires a change to the documentation.
  • I have read the How to Contribute guidelines.

@scicali
Copy link

scicali commented Dec 4, 2023

Date fields should be show/hide by "Select an item" dropdown menu

2023-12-04

@mpuyosa91 mpuyosa91 changed the title Feature date components change proposal Closes #400 - Feature date components change proposal Dec 6, 2023
@mpuyosa91 mpuyosa91 changed the title Closes #400 - Feature date components change proposal Feature date components change proposal Dec 6, 2023
@lukio
Copy link
Contributor

lukio commented Dec 22, 2023

REL #412 #385

@lukio
Copy link
Contributor

lukio commented Jan 5, 2024

Hi all! is there any update regarding this PR? Thanks!

@SignP444
Copy link

I have updated to 8.5, which I find has the same Filter Date issues as above. Would there be any bug fix for v8.5 as the source code is different from your fix. I went from 8.2 to 8.5 before I noticed the bug in 8.5 and unfortunately for me my client use the date filter a lot.
Any advice would be helpful.

@lukio lukio mentioned this pull request Feb 2, 2024
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Status field is dependent on state field but it not responding to changes
5 participants