Language manifest is duplicated and overwritten on each new language install

[horus68]

Issue

Language manifest is duplicated and overwritten on each new language install
Each zip language pack has a "manifest.php" in its root.
When you install a language pack it will store a manifest file in two locations:
1- \upload\upgrades\langpack
Here the manifest.php file name will be changed to the language name tag as in "es-MX-manifest.php" along with the file es-MX.zip (its just an example, it goes for any other language).
This works fine!

2- But the manifest file is also written into instance root, now as "manifest.php". Add this will cause a problem: When you install a second language pack for a different language it writes to \upload\upgrades\langpack but it also write a new "manifest.php" into instance root, so there is a race to be the latest to install!

Expected Behavior

\upload\upgrades\langpack
should be the only place to install language manifest files!

Actual Behavior

The language pack contains a "manifest.php" that is created in the suitecrm instance root and overwritten by each new language pack.

Possible Fix

Change the way language packs are installed.
Along the way also solve the issue when installing an updated language pack before uninstalling the older one #2295

Steps to Reproduce

1- Download a language pack from https://crowdin.com/project/suitecrmtranslations and install!
2- Look into instance root for "manifest.php" and note the language code.
3- Then install a different language pack for any other language
4- Look again into instance root for "manifest.php", it is a new file for the new language code

Context

This is the actual manifest file for master language.

<?PHP
/******************************************
 * SuiteCRM Translations
 * @URL: https://crowdin.com/project/suitecrmtrans
 * @author SuiteCRM Community via Crowdin
 ******************************************/
$manifest = array( 
    'name' => 'English (United Kingdom)',
    'description' => 'Translation: www.crowdin.com/project/suitecrmtranslations',
    'type' => 'langpack',
    'is_uninstallable' => 'Yes',
    'acceptable_sugar_versions' =>
          array (),
    'acceptable_sugar_flavors' =>
          array('CE'),
    'author' => 'SuiteCRM Community',
    'version' => '7.7.5.2',
    'published_date' => '2016-10-06',
      );
$installdefs = array(
    'id'=> 'en_US',
    'image_dir'=>'<basepath>/images',
    'copy' => array(
    array('from'=> '<basepath>/include','to'=>'include'),
    array('from'=> '<basepath>/modules','to'=>'modules'),
    array('from'=> '<basepath>/install','to'=>'install'),
   )
 );
?>

Note that each language pack manifest has some lines localized, as in the above example for es_MX this lines will the different:

    'name' => 'Spanish (Mexico)',
    'id'=> 'es_MX',

Your Environment

• SuiteCRM Version used: Latest version

[pgorod]

I just tried deleting the manifest.php from the root. Then I logged out, logged back in, went into Module Loader. Everything appears to be working fine (although I didn't try to delete modules or upload new ones).

Is this just a matter of avoiding a useless file copy in the installation procedure? Or is the file there for any reason that we know of?

[Dillon-Brown]

@pgorod Doesn't look like it needs to be there. I've put up a fix that should disable this file from being copied.

[horus68]

@Dillon-Brown merge ready?