Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tracking calls in nusoap #5

Closed
judgej opened this issue Dec 17, 2013 · 5 comments
Closed

Tracking calls in nusoap #5

judgej opened this issue Dec 17, 2013 · 5 comments
Labels
Status:Fix Proposed A issue that has a PR related to it that provides a possible resolution Type: Bug Bugs within the core SuiteCRM codebase

Comments

@judgej
Copy link
Contributor

judgej commented Dec 17, 2013

I have been finding a number of places where details of the site are being tracked. If this tracking was open and clear, I would be ignoring it, but it is obfuscated, so in looks it is up to no good and should be removed.

Here is one in includes/nusoap/nusoap.php around line 9315:

            if($operation== "\x73\x75\x67\x61\x72\x48\x6f\x6d\x65" && substr_count($this->endpoint, "\x3a\x2f\x2f\x75\x70\x64\x61\x74\x65\x73\x2e\x73\x75\x67\x61\x72\x63\x72\x6d\x2e\x63\x6f\x6d\x2f\x68\x65\x61\x72\x74\x62\x65\x61\x74\x2f\x73\x6f\x61\x70\x2e\x70\x68\x70") == 0 ){
                    $c2 = new nusoapclient("\x68\x74\x74\x70\x73\x3a\x2f\x2f\x75\x70\x64\x61\x74\x65\x73\x2e\x73\x75\x67\x61\x72\x63\x72\x6d\x2e\x63\x6f\x6d\x2f\x68\x65\x61\x72\x74\x62\x65\x61\x74\x2f\x73\x6f\x61\x70\x2e\x70\x68\x70", false, false, false, false, false, 15, 15);
                    $ping = $c2->call("\x73\x75\x67\x61\x72\x50\x69\x6e\x67", array());
                    if(empty($ping) || $c2->getError()){
                            $c2 = new nusoapclient("\x68\x74\x74\x70\x3a\x2f\x2f\x75\x70\x64\x61\x74\x65\x73\x2e\x73\x75\x67\x61\x72\x63\x72\x6d\x2e\x63\x6f\x6d\x2f\x68\x65\x61\x72\x74\x62\x65\x61\x74\x2f\x73\x6f\x61\x70\x2e\x70\x68\x70", false, false, false, false, false, 15, 15);
                            $c2->call("\x73\x75\x67\x61\x72\x48\x6f\x6d\x65", $params);
                    }
            }

The hex codes translate to:

sugarHome
://updates.sugarcrm.com/heartbeat/soap.php
https://updates.sugarcrm.com/heartbeat/soap.php
sugarPing
http://updates.sugarcrm.com/heartbeat/soap.php
sugarHome

I can do a pull request, but raising it for confirmation first.

@salesagility
Copy link
Collaborator

Yes I agree, this can def be removed, thanks for finding and highlighting this

@judgej
Copy link
Contributor Author

judgej commented Dec 17, 2013

Did you mean to close this? I press the wrong button here all the time ;-)

@salesagility
Copy link
Collaborator

sorry no!

@salesagility salesagility reopened this Dec 17, 2013
@judgej
Copy link
Contributor Author

judgej commented Sep 25, 2014

This is from a while back. Did this get fixed, or is it still waiting for a pull-request? I can pull my finger out and do that if required.

@mattlorimer
Copy link
Member

We have not yet addressed this issue, if you would like to contribute a fix that would be welcome, but it is something we will get around to addressing

@willrennie willrennie added the Type: Bug Bugs within the core SuiteCRM codebase label Nov 19, 2014
@JimMackin JimMackin added the Status:Fix Proposed A issue that has a PR related to it that provides a possible resolution label Jul 10, 2015
mattlorimer pushed a commit that referenced this issue Jan 18, 2016
mattlorimer pushed a commit that referenced this issue Jan 18, 2016
mattlorimer pushed a commit that referenced this issue Mar 15, 2016
samus-aran pushed a commit that referenced this issue Jun 22, 2016
samus-aran pushed a commit that referenced this issue Feb 28, 2017
Twitter connector has moved out of custom/modules and into modules/.
Require_once was including from custom/modules and crashed the app.
@ghost ghost mentioned this issue Jul 18, 2017
@ghost ghost mentioned this issue Feb 26, 2018
samus-aran pushed a commit that referenced this issue Oct 10, 2018
samus-aran pushed a commit that referenced this issue Jun 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Status:Fix Proposed A issue that has a PR related to it that provides a possible resolution Type: Bug Bugs within the core SuiteCRM codebase
Projects
None yet
Development

No branches or pull requests

4 participants