New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
check if conditions value_type is 'Value' before trying to fix the formatting #3
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rmatting condition value fields should not be formatted if their value_type is not 'Value', otherwise, for value_type 'Field', the fields name will be lost if the field type is not string
Merged into hotfix-7.0.2 thanks |
adamjakab
pushed a commit
to BradipoCoder/SuiteCRM
that referenced
this pull request
Apr 7, 2016
samus-aran
pushed a commit
that referenced
this pull request
Jun 22, 2016
samus-aran
pushed a commit
that referenced
this pull request
Mar 25, 2017
ghost
mentioned this pull request
Mar 28, 2017
ghost
mentioned this pull request
Jul 18, 2017
Closed
Closed
This was referenced Feb 15, 2018
ghost
mentioned this pull request
Feb 26, 2018
Closed
6 tasks
6 tasks
This was referenced Sep 17, 2018
samus-aran
pushed a commit
that referenced
this pull request
Oct 10, 2018
* fix some warnings and travis issues
This was referenced Oct 16, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
condition value fields should not be formatted if their value_type is not 'Value', otherwise, for value_type 'Field', the fields name will be lost if the field type is not 'string'