Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#4111 - Problem sending emails from group accounts when inbound email… #4168

Closed

Conversation

stancel
Copy link

@stancel stancel commented Aug 28, 2017

This pull request is meant to help issue #4111 where the "From" dropdown list does not populate for SuiteCRM users that do not have Inbound Email Accounts setup for that user.

Description

This pull request is meant to populate Inbound Email Accounts of Group Accounts into that dropdown to allow sending from them. This way if there was a support@company.com group email setup they could send from it. The code also allows sending from that actual group email by looking up the corresponding email address from the Outbound Email Accounts and using those connection details to send if they are there (otherwise the system email is used). The reply_to_name and from_name in the outgoing email will be populated from the inbound email account chosen in the dropdown list.

Motivation and Context

It is my understanding that this feature has been broken since 7.9.1 and is something I wanted to use for my company in our recently installed version (7.9.4). I saw that other people were asking about it online as well (Github issues and in the forum).

How To Test This

  1. Setup an inbound group email account and corresponding outbound email account to go with it
  2. Login as a SuiteCRM user and navigate to the Email module. Users with and without inbound email accounts should be tried.
  3. Click Compose in the Email module
  4. Once the page loads an AJAX call is made to populate the 'From' dropdown list. Check that it is populated with a group email address.
  5. Send a test email from that group email address and ensure that it sends correctly.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Final checklist

  • My code follows the code style of this project found here.
  • My change requires a change to the documentation.
  • I have read the How to Contribute guidelines.

…nbound email accounts are not setup for that SuiteCRM user but group emails are
@cameronblaikie cameronblaikie added the PR:Community Contribution These are contribution made by the community label Dec 3, 2018
@Dillon-Brown Dillon-Brown added the PR:Wrong Branch Pull requests that point towards a restricted branch such as master label Jan 4, 2019
@Mac-Rae
Copy link
Contributor

Mac-Rae commented Aug 5, 2019

Please rebase this pull request onto hotfix-7.10.x as pull requests directly to master are no longer accepted.

Please take a look at our contribution guidelines for more information.

@SuiteBot
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@jack7anderson7
Copy link
Contributor

Hi @stancel,

We are closing this as both issue 4111 and 5774 have been fixed.

Thanks,
Jack

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR:Community Contribution These are contribution made by the community PR:Wrong Branch Pull requests that point towards a restricted branch such as master
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants