Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/oauth2 clients custom views #5823

Merged

Conversation

PedroErnst
Copy link
Contributor

@PedroErnst PedroErnst commented May 3, 2018

Fixes an issue where the different views for OAuth Clients would not show depending on the client type.

Description

Loads a different edit and detail view depending on the type of client.

How To Test This

Create a Client Credentials type of client.
Create a Password type of client.
See each one displays a different form in edit and detail view.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Final checklist

  • My code follows the code style of this project found here.
  • My change requires a change to the documentation.
  • I have read the How to Contribute guidelines.

Copy link
Contributor

@e-reeley e-reeley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code +1

@Dillon-Brown
Copy link
Contributor

Dillon-Brown commented May 9, 2018

Assessed

Approved with PullApprove

@Dillon-Brown Dillon-Brown merged commit 2f23922 into salesagility:hotfix May 9, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants