Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed - Single quotes breaking tracker URL link in emails from campaigns #7338

Closed
wants to merge 2 commits into from
Closed

Conversation

604media
Copy link
Contributor

@604media 604media commented Jun 6, 2019

No description provided.

@samus-aran
Copy link
Contributor

Hey there @604media

Have a wee look at our workflow process for submitting bugs. https://docs.suitecrm.com/community/contributing-code/bugs/
We don't merged directly into master, so if you want your fix to apply to a particular LTS (8 or 10) then change your base branch to the relevant hotfix branch.

Also Travis is failing, have a quick look why that is and we can help identify how to get it to pass.

@samus-aran samus-aran added the Status:Requires Updates Issues & PRs which requires input or update from the author label Jun 7, 2019
@604media
Copy link
Contributor Author

Thanks @samus-aran
I will create new PR to hotfix-7.10x instead of master. Thanks for providing support document
While coming to Travis - Can you please help to understand my Travis check result

https://travis-ci.org/salesagility/SuiteCRM/builds/542200430?utm_source=github_status&utm_medium=notification

image

Travis passed for PHP 7.1/ MYSQL 5.7 and failed for other versions

image

I'm sure this error not related to our fix - Please suggest me on this.

@samus-aran
Copy link
Contributor

Hey @604media Well if it passed one environment I suspect its down to .. well. travis being flaky unfortunately. I don't want to restart these just to have to do the whole thing again when you create your new PR to the appropriate branch.

Why don't you close this one down and if Travis fails on the new PR then we'll troubleshoot it then.

@Dillon-Brown Dillon-Brown added the PR:Community Contribution These are contribution made by the community label Jun 12, 2019
@samus-aran
Copy link
Contributor

This has been superseeded by #7366

@samus-aran samus-aran closed this Jun 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR:Community Contribution These are contribution made by the community Status:Requires Updates Issues & PRs which requires input or update from the author
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants