Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed - #7337 - Single quotes breaking tracker URL link in emails from campaigns #7366

Open
wants to merge 1 commit into
base: hotfix-7.10.x
Choose a base branch
from

Conversation

604media
Copy link
Contributor

Fixed - #7337 - Single quotes breaking tracker URL link in emails from campaigns

@Dillon-Brown Dillon-Brown added the PR:Community Contribution These are contribution made by the community label Jun 12, 2019
@codecov-io
Copy link

Codecov Report

❗ No coverage uploaded for pull request base (hotfix-7.10.x@8b53e73). Click here to learn what that means.
The diff coverage is 0%.

@@               Coverage Diff                @@
##             hotfix-7.10.x    #7366   +/-   ##
================================================
  Coverage                 ?    7.49%           
================================================
  Files                    ?     3741           
  Lines                    ?   387055           
  Branches                 ?        0           
================================================
  Hits                     ?    29024           
  Misses                   ?   358031           
  Partials                 ?        0

@samus-aran
Copy link
Contributor

samus-aran commented Jun 17, 2019

@604media There is a jssource file that needs to be also altered so when you do a JSMinify that it correctly spits out the excepted.

Please can you include changes to this file, confirm that after you minify JS via Admin panel that is accurately resolves the issue.

https://github.com/salesagility/SuiteCRM/blob/master/jssource/src_files/modules/EmailTemplates/EmailTemplate.js#L163

(Github glitched)

@samus-aran samus-aran added the Status:Requires Updates Issues & PRs which requires input or update from the author label Jun 17, 2019
@Dillon-Brown Dillon-Brown added Status:Requires Updates Issues & PRs which requires input or update from the author and removed Status:Requires Updates Issues & PRs which requires input or update from the author labels Aug 2, 2019
@SuiteBot
Copy link

SuiteBot commented Aug 27, 2020

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR:Community Contribution These are contribution made by the community Status:Requires Updates Issues & PRs which requires input or update from the author
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants