StateChecker: disable save_traces by default #7410
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The saveTraces functionality isn't needed to print the stacktrace so don't depend on it.
It's not used by anything by default and just makes testing harder because it needs more CPU/memory. According to the docs it should be off by default anyway: https://docs.suitecrm.com/developer/automatedtesting/writing-tests/
Dillon-Brown
added
the
PR:Community Contribution
Dillon-Brown
approved these changes
Jun 17, 2019
|
Approved by Travis 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This is a better version of #7087
Motivation and Context
I couldn't run the full test suite on my local machine because they needed too much
memory (>16GB)
How To Test This
Run the unit tests.
Types of changes
Final checklist