InboundEmail mime parser fix #7922
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nstead of real char (e.g. à = =C3=A0; è = =C3=A8)
Codecov Report
@@ Coverage Diff @@
## hotfix-7.10.x #7922 +/- ##
=================================================
+ Coverage 7.27% 7.29% +0.01%
=================================================
Files 3700 3701 +1
Lines 386188 386105 -83
=================================================
+ Hits 28106 28154 +48
+ Misses 358082 357951 -131 |
|
Looks good, Assessed 👍 |
Dillon-Brown
force-pushed
the
fix/email_encoding
branch
from
cc4bc11
to
13824a3
Compare
…encoding # Conflicts: # composer.lock
mattlorimer
previously requested changes
Sep 30, 2019
This change allows us to detect the header type of inbound emails and prevents html being cleaned when the type is "text/plain".
This change populated the email->description field when the type of inbound email is plaintext.
6 tasks
|
retested and it still not populating the description field when I import an email (e.g create a case import) looks like you update it only on returnNonImportedEmail and not returnImportedEmail |
mattlorimer
added
the
Status:Requires Updates
Dillon-Brown
removed
the
Status:Requires Updates
…encoding # Conflicts: # composer.json # composer.lock
code-ph0y
approved these changes
Oct 22, 2019
Mac-Rae
added
the
Status:In Review
|
Reassessed and LGTM 👍 |
cameronblaikie
added
Status:Assessed
Dillon-Brown
dismissed
mattlorimer’s stale review
Raised issues have been addressed and PR re code-reviewed + assessed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes an issue with the email body encoding and broken multipart/alternative emails. This PR also starts to refactor InboundEmail.php to use zbateson/mail-mime-parser.
This should, in theory, reduce a large amount of the email issues and regressions we receive in relation to improper email parsing while also reducing the overall complexity of inbound email handling in SuiteCRM.
Motivation and Context
Issue reference: #7880
How To Test This
This will require full testing of the email module. A few key areas I would recommend testing is the inline images functionality, attachments and HTML styling. This should be consistent across unimported and imported emails.
Types of changes
Final checklist