Fixed #8177 & related bugs to show the correct "From" email information #8254
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…il information Also fixes: -salesagility#8177-Email sent from case does not have the correct "From" information -salesagility#7407-"Users may send as themselves" broken - Invalid address: (punyEncode) -salesagility#7692-From adress incorrect when replying to email Reintroduced the code that was removed as a fix for salesagility#7407 and fixed it by checking for the case within the condition. Resolves: salesagility#8177, salesagility#7692, salesagility#7407
|
Since the travis check has been pending for 2+ days, the recommendation was to open a new PR according to https://suitecrm.com/suitecrm/forum/developer-help/28099-pull-request-waiting-on-travis-status-for-1-day-https-github-com-salesagility-suitecrm-pull-8254 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also fixes:
-#7407-"Users may send as themselves" broken - Invalid address: (punyEncode)
-#7692-From adress incorrect when replying to email
Reintroduced the code that was removed as a fix for #7407 and fixed it
by checking for the case within the condition.
Resolves: #8177, #7692, #7407
Description
Reintroduced the code that was removed which was causing issues #8177 & #7692 as a fix for #7407 and fixed the #7407 issue by checking for the case within the condition.
Motivation and Context
Fixed bugs.
How To Test This
Please look at the resolved issue for more information on testing this fix.
Types of changes
Final checklist