Add cases to email object_arr #8587
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## hotfix-7.10.x #8587 +/- ##
=================================================
+ Coverage 10.73% 10.73% +<.01%
=================================================
Files 3229 3229
Lines 240855 240851 -4
=================================================
+ Hits 25858 25860 +2
+ Misses 214997 214991 -6 |
|
Actually thinking about it why do we even check against of allowed types, why not just try to load the bean if parent/id are supplied and its in list of beans? |
|
|
mattlorimer
force-pushed
the
hotfix-7.10.x
branch
2 times, most recently
from
3149dea
to
ab954a4
Compare
mattlorimer
force-pushed
the
hotfix-7.10.x
branch
from
1609e8b
to
b06335d
Compare
|
Can we merge this in, so simple but would help make things easier in our pipeline. |
Dillon-Brown
previously approved these changes
Jun 17, 2021
Cases parent_type to be pulled for Email Template
Dillon-Brown
approved these changes
Jun 17, 2021
jack7anderson7
approved these changes
Jul 18, 2021
jack7anderson7
added
the
Status:Assessed
samus-aran
approved these changes
Aug 10, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cases parent_type to be pulled for Email Template