Fixes: broken UX, broken API specs #9375
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Avoids the following error, an error-message in frontend and a broken UX [error] 94446#0: *1056 FastCGI sent in stderr: "PHP message: PHP Notice: Trying to access array offset on value of type null in SuiteCRM/modules/AOW_WorkFlow/AOW_WorkFlow.php on line 177
|
|
Avoids server error: PHP message: PHP Deprecated: Non-static method StudioParser::buildImageButtons() should not be called statically in /Users/trumva/PhpstormProjects/SuiteCRM-Core/public/legacy/modules/Studio/wizards/RenameModules.php on line 339
Presently we do not comply with JSON:API specs, see: https://jsonapi.org/format/#error-objects This leads to incompatibility with proper PSR-7 implementations such as https://github.com/Nyholm/psr7 (recommended by Symfony). "Warning: array_key_exists() expects parameter 2 to be array, int given" Sadly we cannnot use excellent JSON API Client packages such as: https://github.com/eosnewmedia/JSON-API-Client It is not possible to extend the deserializer because at this point we lost the required array key (e.g. 'status'). Thus do it the proper way and make our error response compatible with specs. TODO (maybe): There is another issue with the prefixed Api V8 and 'module' string but this issue can be worked around.
|
Hi @myfluxi, Could you please update your pull request to point to the hotfix-7.10.x branch. Thanks, |
jack7anderson7
added
the
PR:Wrong Branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[error] 94446#0: *1056 FastCGI sent in stderr: "PHP message: PHP Notice: Trying to access array offset on value of type null in SuiteCRM/modules/AOW_WorkFlow/AOW_WorkFlow.php on line 177
Description
Error occured while fetching metadataERROR Error: Uncaught (in promise): Error: Internal server error[error] 94446#0: *1056 FastCGI sent in stderr: "PHP message: PHP Notice: Trying to access array offset on value of type null in SuiteCRM/public/legacy/modules/AOW_WorkFlow/AOW_WorkFlow.php on line 177In a fresh install, add WorkFlow to the main menu and try to access it. Error is shown.
Motivation and Context
This change solves a broken UX.
How To Test This
See above
Types of changes
Final checklist