Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix #6756 - Add Label to Dynamic Fields #9795

Merged
merged 1 commit into from
Nov 9, 2022
Merged

Fix #6756 - Add Label to Dynamic Fields #9795

merged 1 commit into from
Nov 9, 2022

Conversation

jack7anderson7
Copy link
Contributor

Fix #6756

Description

Add LBL_INSERT_FIELDS to Dynamic Enum Language file

Motivation and Context

How To Test This

Go to the page shown in #6756, see that the label now shows as expected.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Final checklist

  • My code follows the code style of this project found here.
  • My change requires a change to the documentation.
  • I have read the How to Contribute guidelines.

@likhobory
Copy link
Contributor

likhobory commented Oct 19, 2022 •
edited
Loading

@jack7anderson7

This is probably a typo, it should be:
'LBL_INSERT_FIELD' => 'Insert Field'

clemente-raposo
clemente-raposo approved these changes Oct 26, 2022
View reviewed changes
Copy link
Contributor

@clemente-raposo clemente-raposo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@clemente-raposo clemente-raposo added Hacktoberfest Issues & PRs that count towards Hacktoberfest Status: Passed Code Review Mark issue has passed code review reviewed labels Oct 26, 2022
@johnM2401 johnM2401 added Status: Passed Testing Status: Ready to Merge PRs that have passed QA & can be merged into next release batch labels Oct 26, 2022
johnM2401
johnM2401 approved these changes Oct 26, 2022
View reviewed changes
Copy link
Contributor

@johnM2401 johnM2401 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jack7anderson7 jack7anderson7 merged commit 2985df1 into salesagility:hotfix Nov 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@clemente-raposo clemente-raposo clemente-raposo approved these changes

@johnM2401 johnM2401 johnM2401 approved these changes

Assignees
No one assigned
Labels
Hacktoberfest Issues & PRs that count towards Hacktoberfest Status: Passed Code Review Mark issue has passed code review reviewed Status: Passed Testing Status: Ready to Merge PRs that have passed QA & can be merged into next release batch
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jack7anderson7 @likhobory @clemente-raposo @johnM2401