-
Notifications
You must be signed in to change notification settings - Fork 812
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Should button icons change color when the button is disabled? #43
Comments
Yes, it should. And when I test it, it does. Can you show me a case where this doesn't happen so I can see what's going on? |
I was hoping the icon could automatically match the disabled text's color. Currently messing around with the CSS framework here (running 0.9.2): https://dl.dropboxusercontent.com/u/43912228/_TO/app/prototype-lightning/prototype_view-applicants.html |
Ahhh, good catch. I tested on a button using slightly different markup. Thanks, I'll fix this. It should make the next release. |
Ahhh, I just realized this was fixed with an update I did for a different bug this week (using the currentColor value). I'm going to close this one and you'll have what you need in the next release. |
Updated and clarified Icon docs and JS for tabs
It seems like any button icon's color should match the text color IF the button is disabled. Is the intent to have the icon be the same blue all of the time?
The text was updated successfully, but these errors were encountered: