ignoring cardinality in modelinsights serialization (#474)

* ignoring cardinality at modelinsights serialization * get rid of empty test * update the counter part of the test case, making it more understandable
salesforce · May 11, 2020 · 7d0c33e · 7d0c33e
1 parent dc33ada
commit 7d0c33e
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 1 deletion.
diff --git a/core/src/main/scala/com/salesforce/op/ModelInsights.scala b/core/src/main/scala/com/salesforce/op/ModelInsights.scala
@@ -408,11 +408,15 @@ case object ModelInsights {
         { case x: EvalMetric => JString(x.entryName) }
       )
     )
+    val featureDistributionSerializer = FieldSerializer[FeatureDistribution](
+      FieldSerializer.ignore("cardEstimate")
+    )
     Serialization.formats(typeHints) +
       EnumEntrySerializer.json4s[ValidationType](ValidationType) +
       EnumEntrySerializer.json4s[ProblemType](ProblemType) +
       new SpecialDoubleSerializer +
-      evalMetricsSerializer
+      evalMetricsSerializer +
+      featureDistributionSerializer
   }
 
   /**

diff --git a/core/src/test/scala/com/salesforce/op/ModelInsightsTest.scala b/core/src/test/scala/com/salesforce/op/ModelInsightsTest.scala
@@ -456,6 +456,8 @@ class ModelInsightsTest extends FlatSpec with PassengerSparkFixtureTest with Dou
             i.featureName shouldEqual o.featureName
             i.featureType shouldEqual o.featureType
             i.derivedFeatures.zip(o.derivedFeatures).foreach { case (ii, io) => ii.corr shouldEqual io.corr }
+            i.distributions.foreach { i => i.cardEstimate should not be None}
+            o.distributions.foreach { o => o.cardEstimate shouldEqual None}
             RawFeatureFilterResultsComparison.compareSeqMetrics(i.metrics, o.metrics)
             RawFeatureFilterResultsComparison.compareSeqDistributions(i.distributions, o.distributions)
             RawFeatureFilterResultsComparison.compareSeqExclusionReasons(i.exclusionReasons, o.exclusionReasons)
@@ -968,4 +970,5 @@ class ModelInsightsTest extends FlatSpec with PassengerSparkFixtureTest with Dou
       "second" -> classOf[SingleMetric]
     )
   }
+
 }