Error in transmogrifai gen when field has an underscore

[wdearden]

Describe the bug
I discovered this bug while using the Bootstrap Your First Project docs (https://docs.transmogrif.ai/en/stable/examples/Bootstrap-Your-First-Project.html) on a csv that I have. transmogrifai gen errors out when a field name has an underscore in it.

To Reproduce
Replace Pclass with P_class in test-data/PassengerDataAll.avsc and Pclass with P_class in cli/passengers.answers.
Run from the main TransmogrifAI directory:

./gradlew cli:shadowJar
alias transmogrifai="java -cp `pwd`/cli/build/libs/\* com.salesforce.op.cli.CLI"
transmogrifai gen --input `pwd`/test-data/PassengerDataAll.csv \
  --id passengerId --response survived \
  --schema `pwd`/test-data/PassengerDataAll.avsc \
  --answers cli/passengers.answers Titanic --overwrite

cd titanic
./gradlew compileTestScala installDist

Expected behavior
I expect the last line to compile without error.

Logs or screenshots

ch-nb-3908:titanic wdearden$ ./gradlew compileTestScala installDist

> Task :compileScala
Pruning sources from previous analysis, due to incompatible CompileSetup.
/Users/wdearden/repos/oss/TransmogrifAI/titanic/src/main/scala/com/salesforce/app/Features.scala:17: value getP_class is not a member of com.salesforce.app.schema.Passenger
    .extract(asPickList(_.getP_class))
                          ^
one error found

> Task :compileScala FAILED

FAILURE: Build failed with an exception.

* What went wrong:
Execution failed for task ':compileScala'.
> Compilation failed

* Try:
Run with --stacktrace option to get the stack trace. Run with --info or --debug option to get more log output. Run with --scan to get full insights.

* Get more help at https://help.gradle.org

BUILD FAILED in 13s
3 actionable tasks: 3 executed
ch-nb-3908:titanic wdearden$ ./gradlew compileTestScala installDist

> Task :compileScala
Pruning sources from previous analysis, due to incompatible CompileSetup.
/Users/wdearden/repos/oss/TransmogrifAI/titanic/src/main/scala/com/salesforce/app/Features.scala:17: value getP_class is not a member of com.salesforce.app.schema.Passenger
    .extract(asPickList(_.getP_class))
                          ^
one error found

> Task :compileScala FAILED

FAILURE: Build failed with an exception.

* What went wrong:
Execution failed for task ':compileScala'.
> Compilation failed

* Try:
Run with --stacktrace option to get the stack trace. Run with --info or --debug option to get more log output. Run with --scan to get full insights.

* Get more help at https://help.gradle.org

BUILD FAILED in 6s
3 actionable tasks: 2 executed, 1 up-to-date

Additional context
This also fails when reading from csv and using the --auto workflow.

[vpatryshev]

Working on it now.

…

On Wed, Jan 9, 2019, 17:34 William Dearden ***@***.*** wrote: *Describe the bug* I discovered this bug while using the Bootstrap Your First Project docs ( https://docs.transmogrif.ai/en/stable/examples/Bootstrap-Your-First-Project.html) on a csv that I have. transmogrifai gen errors out when a field name has an underscore in it. *To Reproduce* Replace Pclass with P_class in test-data/PassengerDataAll.avsc and Pclass with P_class in cli/passengers.answers. Run from the main TransmogrifAI directory: ./gradlew cli:shadowJar alias transmogrifai="java -cp `pwd`/cli/build/libs/\* com.salesforce.op.cli.CLI" transmogrifai gen --input `pwd`/test-data/PassengerDataAll.csv \ --id passengerId --response survived \ --schema `pwd`/test-data/PassengerDataAll.avsc \ --answers cli/passengers.answers Titanic --overwrite cd titanic ./gradlew compileTestScala installDist *Expected behavior* I expect the last line to compile without error. *Logs or screenshots* ch-nb-3908:titanic wdearden$ ./gradlew compileTestScala installDist > Task :compileScala Pruning sources from previous analysis, due to incompatible CompileSetup. /Users/wdearden/repos/oss/TransmogrifAI/titanic/src/main/scala/com/salesforce/app/Features.scala:17: value getP_class is not a member of com.salesforce.app.schema.Passenger .extract(asPickList(_.getP_class)) ^ one error found > Task :compileScala FAILED FAILURE: Build failed with an exception. * What went wrong: Execution failed for task ':compileScala'. > Compilation failed * Try: Run with --stacktrace option to get the stack trace. Run with --info or --debug option to get more log output. Run with --scan to get full insights. * Get more help at https://help.gradle.org BUILD FAILED in 13s 3 actionable tasks: 3 executed ch-nb-3908:titanic wdearden$ ./gradlew compileTestScala installDist > Task :compileScala Pruning sources from previous analysis, due to incompatible CompileSetup. /Users/wdearden/repos/oss/TransmogrifAI/titanic/src/main/scala/com/salesforce/app/Features.scala:17: value getP_class is not a member of com.salesforce.app.schema.Passenger .extract(asPickList(_.getP_class)) ^ one error found > Task :compileScala FAILED FAILURE: Build failed with an exception. * What went wrong: Execution failed for task ':compileScala'. > Compilation failed * Try: Run with --stacktrace option to get the stack trace. Run with --info or --debug option to get more log output. Run with --scan to get full insights. * Get more help at https://help.gradle.org BUILD FAILED in 6s 3 actionable tasks: 2 executed, 1 up-to-date *Additional context* This also fails when reading from csv and using the --auto workflow. — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <#205>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAOuKwk8B8HK4GinbwVorknywslJ7IjQks5vBpjCgaJpZM4Z4nzI> .

[vpatryshev]

This PR fixes the issue.

[wdearden]

Awesome. Thanks!