Fixing code generation bug with underscores in names #208
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…score in names. Avro converts them to CamelCase; so we have to do the same. A test case added, and a couple of test files. Also, slightly improved error reporting in command line. Also, gradlew updated to work correctly on newer versions of jvm.
|
Thanks for the contribution! Before we can merge this, we need @vpatryshev to sign the Salesforce.com Contributor License Agreement. |
Codecov Report
@@ Coverage Diff @@
## master #208 +/- ##
===========================================
- Coverage 86.36% 68.19% -18.18%
===========================================
Files 310 310
Lines 10132 10136 +4
Branches 353 548 +195
===========================================
- Hits 8751 6912 -1839
- Misses 1381 3224 +1843
Continue to review full report at Codecov.
|
Codecov Report
@@ Coverage Diff @@
## master #208 +/- ##
==========================================
- Coverage 86.36% 86.34% -0.03%
==========================================
Files 310 310
Lines 10132 10136 +4
Branches 353 548 +195
==========================================
+ Hits 8751 8752 +1
- Misses 1381 1384 +3
Continue to review full report at Codecov.
|
tovbinm
approved these changes
Jan 14, 2019
|
Just makes life easier on some occasions.
Thanks,
-Vlad
…On Sun, Jan 13, 2019 at 8:41 PM Matthew Tovbin ***@***.***> wrote:
***@***.**** approved this pull request.
lgtm, one minor comment on pwd
------------------------------
In cli/src/main/scala/com/salesforce/op/cli/CommandParser.scala
<#208 (comment)>
:
> @@ -47,9 +47,12 @@ trait OpCli {
else success
}
+ private[cli] def tweak(file: File): File =
+ new File(file.getPath.replace("`pwd`/", ""))
why do we need to hack around pwd?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#208 (review)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAOuK3isUNuZaHotjHd5NuYwwl82kQVKks5vDApfgaJpZM4Z88qz>
.
|
|
Can we merge it? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issues
see issue 205
Describe the proposed solution
Since avro converts names with underscores to CamelCase, we need to refer those CamelCase accessors as generated by avro. Test and test data added.
Describe alternatives you've considered
Could probably tweak avro code generation logic, but why.
We could also use CamelCase in our code, but this seems more confusing.
Additional context
Also, gradlew was tweaked to care about the cases when your jvm is not 8.0, and deprecated flags are not being used anymore.