Make model selector metadata to metric more robust #386
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #386 +/- ##
==========================================
+ Coverage 86.85% 86.86% +<.01%
==========================================
Files 336 336
Lines 10950 10956 +6
Branches 351 578 +227
==========================================
+ Hits 9511 9517 +6
Misses 1439 1439
Continue to review full report at Codecov.
|
leahmcguire
reviewed
Aug 20, 2019
| nm -> JsonUtils.fromString[MultiClassificationMetrics](valsJson).get | ||
| case OpEvaluatorNames.Regression.humanFriendlyName => | ||
| case `regression` => |
There was a problem hiding this comment.
hmm, it is better not to have this hard coded as text, but I noticed a problem with matching in Enumns in my PR as well... @tovbinm is this related to the upgrade?
|
@erica-chiu proposed tests are defining the custom evaluator incorrectly. Here is how is supposed to work #387 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issues
Describe the proposed solution
Change the matching when parsing model selector metadata into metrics from name of metric to metric keys
Describe alternatives you've considered
N/A
Additional context
Allows for parsing of metadata to be based on content rather than the name, allowing for multiple metrics of the same type