Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ModelInsightsTest flakiness due to coefficients turning negative #407

Merged
merged 1 commit into from
Sep 12, 2019

Conversation

TuanNguyen27
Copy link
Collaborator

ModelInsightsTest was flaky due to returned coefficients being negative sometimes.

Describe the proposed solution
Adding absolute value when summing descaled coefficients

Copy link
Contributor

@gerashegalov gerashegalov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov
Copy link

codecov bot commented Sep 12, 2019

Codecov Report

Merging #407 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##           master     #407    +/-   ##
========================================
  Coverage   86.95%   86.95%            
========================================
  Files         337      337            
  Lines       11060    11060            
  Branches      357      591   +234     
========================================
  Hits         9617     9617            
  Misses       1443     1443

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0759cb5...b7852ed. Read the comment docs.

@gerashegalov gerashegalov changed the title Take absolute value when calculating ratio of difference between scaled and descaled coefficient Fix ModelInsightsTest flakiness due to coefficients turning negative Sep 12, 2019
@gerashegalov gerashegalov merged commit 0235f26 into master Sep 12, 2019
@gerashegalov gerashegalov deleted the tn/abs branch September 12, 2019 23:22
@sanmitra sanmitra mentioned this pull request Oct 11, 2019
@nicodv nicodv mentioned this pull request Jun 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants