Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

removed logging of tokens #420

Merged
merged 2 commits into from
Oct 11, 2019
Merged

removed logging of tokens #420

merged 2 commits into from
Oct 11, 2019

Conversation

leahmcguire
Copy link
Collaborator

Related issues
Refer to issue(s) addressed in this pull request from Issues page.

Describe the proposed solution
A clear and concise description of what the changes are.

Describe alternatives you've considered
A clear and concise description of any alternative solutions or features you've considered.

Additional context
Add any other context about the changes here.

@codecov
Copy link

codecov bot commented Oct 11, 2019

Codecov Report

Merging #420 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##           master     #420    +/-   ##
========================================
  Coverage   86.97%   86.97%            
========================================
  Files         337      337            
  Lines       11078    11078            
  Branches      369      597   +228     
========================================
  Hits         9635     9635            
  Misses       1443     1443
Impacted Files Coverage Δ
...om/salesforce/op/filters/FeatureDistribution.scala 98.63% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6589656...2b7077e. Read the comment docs.

@leahmcguire leahmcguire merged commit a83bf46 into master Oct 11, 2019
@leahmcguire leahmcguire deleted the lm/logging branch October 11, 2019 18:07
@@ -167,7 +167,6 @@ case class FeatureDistribution
"nulls" -> nulls.toString,
"distribution" -> distribution.mkString("[", ",", "]"),
"summaryInfo" -> summaryInfo.mkString("[", ",", "]"),
"cardinality" -> cardEstimate.map(_.toString).getOrElse(""),
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@leahmcguire was there any value in what @TuanNguyen27 was doing in e0ea2ed#diff-528878f8bd336b485dd82f1fbef950f7R281

seq.map(_.size.toString)

which we could still do in toString

@salesforce-cla
Copy link

Thanks for the contribution! Unfortunately we can't verify the commit author(s): leahmcguire <l***@s***.com>. One possible solution is to add that email to your GitHub account. Alternatively you can change your commits to another email and force push the change. After getting your commits associated with your GitHub account, refresh the status of this Pull Request.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants