Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement standard rule layout #30

Closed
plaird opened this issue Mar 27, 2020 · 4 comments
Closed

Implement standard rule layout #30

plaird opened this issue Mar 27, 2020 · 4 comments

Comments

@plaird
Copy link
Contributor

plaird commented Mar 27, 2020

We started this rule back in the days of Bazel 0.5.2 and have kept the same layout since. We need to reorganize the rule to adhere to the standard layout:

https://docs.bazel.build/versions/master/skylark/deploying.html#repository-content

@plaird
Copy link
Contributor Author

plaird commented Jan 15, 2021

This work will also require a rename of the Git repository from bazel-springboot-rule to rules-spring

@plaird
Copy link
Contributor Author

plaird commented Mar 1, 2021

I think we should also be looking at bzl_library during this work.

https://github.com/bazelbuild/bazel-skylib/blob/master/bzl_library.bzl

This might be required to support stardoc #28 ?

plaird added a commit that referenced this issue Mar 13, 2021
@plaird
Copy link
Contributor Author

plaird commented Mar 13, 2021

The repackaging work (aside from the repo rename) has been completed an is in the repackaging_v2.0 branch. I will publish a new release from this branch. It has been tested internally at Salesforce. The top-level README will be updated with the migration details.

  • I will rename the repo after further testing, to ensure that GitHub will properly redirect requests from the old repo to the new repo name.
  • I will merge the 2.0 branch into master soon.

plaird added a commit that referenced this issue Mar 13, 2021
plaird added a commit that referenced this issue Mar 17, 2021
@plaird plaird moved this from To do to In progress in Release 2.0: Modernize Rule Name and Layout Mar 17, 2021
@plaird
Copy link
Contributor Author

plaird commented Mar 17, 2021

The repo rename happened in #97 and the docs have been updated. I think we are done!

Now that we are in proper attire, I just sent a PR to finally get us added to AwesomeBazel: jin/awesome-bazel#94

@plaird plaird closed this as completed Mar 17, 2021
@plaird plaird moved this from In progress to Done in Release 2.0: Modernize Rule Name and Layout Mar 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
Development

No branches or pull requests

1 participant