fix: performance comment (#176)

salesforce · Jul 22, 2019 · 52d9d3e · 52d9d3e
1 parent 897c1f9
commit 52d9d3e
Showing 1 changed file with 2 additions and 2 deletions.
diff --git a/packages/@best/github-integration/src/index.ts b/packages/@best/github-integration/src/index.ts
@@ -140,8 +140,8 @@ export async function completeBenchmarkComparisonCheck(gitHubInstallation: Octok
     const averageChange = calculateAverageChange(comparison);
     const highThreshold = Math.abs(globalConfig.commentThreshold); // handle whether the threshold is positive or negative
     const lowThreshold = -1 * highThreshold;
-    const significantlyRegressed = averageChange < lowThreshold; // less than a negative is WORSE
-    const significantlyImproved = averageChange > highThreshold; // more than a positive is GOOD
+    const significantlyImproved = averageChange < lowThreshold; // less than a negative is GOOD (things got faster)
+    const significantlyRegressed = averageChange > highThreshold; // more than a positive is WORSE (things got slower)
 
     if ((significantlyRegressed || significantlyImproved) && PULL_REQUEST_URL !== undefined) {
         const prId: any = PULL_REQUEST_URL.split('/').pop();