fix(best-frontend): Fix Tab switching (#73)

* fix(best-frontend): Fix Tab switching * Change default title
salesforce · Feb 6, 2018 · 57f2d08 · 57f2d08
1 parent aad9365
commit 57f2d08
Show file tree

Hide file tree

Showing 13 changed files with 23 additions and 25 deletions.
diff --git a/packages/best-frontend/public/index.html b/packages/best-frontend/public/index.html
@@ -2,7 +2,7 @@
 <html lang="en" data-framework="raptor">
 <head>
   <meta charset="UTF-8">
-  <title>Raptor SFX Shell</title>
+  <title>LWC performance</title>
   <link rel="stylesheet" href="/assets/styles/salesforce-lightning-design-system.min.css">
   <link rel="stylesheet" href="/assets/styles/index.css">
   {JS_PRELOAD}

diff --git a/packages/best-frontend/server/api_v1.js b/packages/best-frontend/server/api_v1.js
@@ -82,7 +82,6 @@ function addRoutes(router, store) {
 
 async function getLastCommitStats(store, projectName, branch, size = 30) {
     const commits = await store.getCommits(projectName, branch);
-    console.log(`>>> ${projectName}/${branch}`, commits);
     const lastCommits = commits.slice(0, size);
     return Promise.all(lastCommits.map(async (commit) => {
         let benchmarks = await memoizedGetBenchPerCommit(projectName, commit);

diff --git a/packages/best-frontend/src/modules/one/app-nav-bar-item-root/app-nav-bar-item-root.js b/packages/best-frontend/src/modules/one/app-nav-bar-item-root/app-nav-bar-item-root.js
@@ -1,4 +1,4 @@
-import { Element } from 'engine';
+import { api, Element } from 'engine';
 import { isPureLeftClick } from 'one-tmp-utils';
 
 const Labels = {

diff --git a/packages/best-frontend/src/modules/one/app-nav-bar-menu-item/app-nav-bar-menu-item.js b/packages/best-frontend/src/modules/one/app-nav-bar-menu-item/app-nav-bar-menu-item.js
@@ -1,4 +1,4 @@
-import { Element } from "engine";
+import { api, Element } from "engine";
 import { joinClassNames, isPureLeftClick } from "one-tmp-utils";
 
 export default class LightningMenuItem extends Element {

diff --git a/packages/best-frontend/src/modules/one/app-router/app-router.js b/packages/best-frontend/src/modules/one/app-router/app-router.js
@@ -1,4 +1,4 @@
-import { Element } from 'engine';
+import { api, Element } from 'engine';
 import HomePage from "./page-home.html";
 import ProjectPage from "./page-project.html";
 export default class AppRouter extends Element {

diff --git a/packages/best-frontend/src/modules/one/app/app.js b/packages/best-frontend/src/modules/one/app/app.js
@@ -1,4 +1,4 @@
-import { Element, unwrap } from 'engine';
+import { Element, unwrap, track } from 'engine';
 import INITIAL_STATE from './state';
 import { reifyBranches, emulateFetch, initializeState, normalizeStats, updateURL} from './utils';
 
@@ -42,6 +42,7 @@ export default class App extends Element {
     async setProjectLastestStats(project, branch = "master") {
         const projectBranch = `${project}:${branch}`;
         if (!this.state.lastCommits[projectBranch]) {
+            this.state.pageState = {};
             const response = await fetch(`/api/v1/projects/${project}/${branch}/lastcommits`);
             if (response.ok) {
                 const stats = await response.json();

diff --git a/packages/best-frontend/src/modules/one/appnav/appnav.js b/packages/best-frontend/src/modules/one/appnav/appnav.js
@@ -1,4 +1,4 @@
-import { Element } from 'engine';
+import { api, Element } from 'engine';
 import { isPureLeftClick } from 'one-tmp-utils';
 const NAV_TYPE_HORIZONTAL = 'horizontal';
 const NAV_TYPE_DROPDOWN = 'dropdown';

diff --git a/packages/best-frontend/src/modules/one/page-project-panel/page-project-panel.js b/packages/best-frontend/src/modules/one/page-project-panel/page-project-panel.js
@@ -1,4 +1,4 @@
-import { Element } from 'engine';
+import { api, Element } from 'engine';
 
 export default class ComparePanel extends Element {
     @api selectedCommitBenchmarks;

diff --git a/packages/best-frontend/src/modules/one/page-project/page-project.html b/packages/best-frontend/src/modules/one/page-project/page-project.html
@@ -4,7 +4,7 @@
             <template if:true={isDataReady}>
                 <section class="charts">
                     <template for:each={benchmarks} for:item="benchmark">
-                        <div class="benchmark" data-id={benchmark}></div>
+                        <div key={benchmark} class="benchmark" data-id={benchmark}></div>
                     </template>
                 </section>
             </template>

diff --git a/packages/best-frontend/src/modules/one/page-project/page-project.js b/packages/best-frontend/src/modules/one/page-project/page-project.js
@@ -1,4 +1,4 @@
-import { Element } from 'engine';
+import { api, track, Element } from 'engine';
 import { normalizeForTrending, normalizeForComparison } from "./normalize-benchmarks";
 import { generatePlot, cleanupPlots, isPlot } from "./plots";
 
@@ -15,22 +15,20 @@ export default class HomePage extends Element {
 
     @api set projectState(newState) {
         const { commitBenchmarks } = newState;
-        if (commitBenchmarks) {
-            this._projectState = newState;
-            this.benchmarksTrend = normalizeForTrending(commitBenchmarks);
+        this._projectState = newState;
+        this.benchmarksTrend = normalizeForTrending(commitBenchmarks);
 
-            // TODO: remove me one we have the logc for clicking correct
-            if (commitBenchmarks.length && this.benchmarksTrend && !this.selectedCommits.length) {
-                this.selectedCommits.push({
-                    commit: newState.commits[newState.commits.length - 1],
-                    benchmarkName: Object.keys(this.benchmarksTrend)[0]
-                });
-            }
-        }
+        // TODO: remove me one we have the logc for clicking correct
+        // if (commitBenchmarks && commitBenchmarks.length && this.benchmarksTrend && !this.selectedCommits.length) {
+        //     this.selectedCommits.push({
+        //         commit: newState.commits[newState.commits.length - 1],
+        //         benchmarkName: Object.keys(this.benchmarksTrend)[0]
+        //     });
+        // }
     }
 
     get isDataReady() {
-        return !!this.benchmarksTrend;
+        return !!(this.benchmarksTrend && Object.keys(this.benchmarksTrend).length);
     }
     get benchmarks() {
         return Object.keys(this.benchmarksTrend);

diff --git a/packages/best-frontend/src/modules/one/tmp-icon/tmp-icon.js b/packages/best-frontend/src/modules/one/tmp-icon/tmp-icon.js
@@ -1,4 +1,4 @@
-import { Element } from 'engine';
+import { api, Element } from 'engine';
 import { classListMutation, icon as iconUtil } from 'one-tmp-utils';
 
 const validVariants = new Set([

diff --git a/packages/best-frontend/src/modules/one/tmp-menu-item/tmp-menu-item.js b/packages/best-frontend/src/modules/one/tmp-menu-item/tmp-menu-item.js
@@ -1,4 +1,4 @@
-import { Element } from "engine";
+import { api, Element } from "engine";
 import { joinClassNames, isPureLeftClick } from "one-tmp-utils";
 
 export default class LightningMenuItem extends Element {

diff --git a/packages/best-frontend/src/modules/one/tmp-spinner/tmp-spinner.js b/packages/best-frontend/src/modules/one/tmp-spinner/tmp-spinner.js
@@ -1,4 +1,4 @@
-import { Element } from "engine";
+import { Element, api } from "engine";
 import { joinClassNames } from "one-tmp-utils";
 
 export default class LightningSpinner extends Element {