fix: New Best Logos in Frontend (#183)

salesforce · Jul 26, 2019 · 97e25dd · 97e25dd
1 parent a2eee9a
commit 97e25dd
Show file tree

Hide file tree

Showing 10 changed files with 15 additions and 14 deletions.
diff --git a/packages/@best/agent-frontend/src/client/index.html b/packages/@best/agent-frontend/src/client/index.html
@@ -2,7 +2,7 @@
 <html lang="en">
     <head>
         <meta charset="utf-8">
-        <title>Best Agent Dashboard</title>
+        <title>Best Dashboard</title>
         <style>
             body {
                 font-family: Arial, Helvetica, sans-serif;

diff --git a/packages/@best/agent-frontend/src/client/resources/favicon.ico b/packages/@best/agent-frontend/src/client/resources/favicon.ico
diff --git a/packages/@best/agent-frontend/src/client/resources/lwc.png b/packages/@best/agent-frontend/src/client/resources/lwc.png
diff --git a/packages/@best/frontend/src/index.html b/packages/@best/frontend/src/index.html
@@ -13,6 +13,7 @@
             }
         </style>
         <meta name="viewport" content="width=device-width,initial-scale=1" />
+        <link rel="shortcut icon" href="/resources/favicon.ico">
         <script src="https://cdn.plot.ly/plotly-1.48.1.min.js"></script>
     </head>
     <body>

diff --git a/packages/@best/frontend/src/modules/store/api/api.js b/packages/@best/frontend/src/modules/store/api/api.js
@@ -15,20 +15,20 @@ function timeQuery(project, timing) {
         return `since=${date.getTime()}`
     }
 
-    return ''
+    return '';
 }
 
 export async function fetchProjects() {
     const response = await fetch(createURL('projects'));
     const { projects } = await response.json();
-    return projects
+    return projects || [];
 }
 
 export async function fetchSnapshots(project, timing) {
     const timeParams = timeQuery(project, timing);
     const response = await fetch(createURL(`${project.id}/snapshots?${timeParams}`));
     const { snapshots } = await response.json();
-    return snapshots;
+    return snapshots || []; 
 }
 
 export async function fetchCommitInfo(commit) {

diff --git a/packages/@best/frontend/src/modules/store/store/urlstorage.js b/packages/@best/frontend/src/modules/store/store/urlstorage.js
@@ -20,6 +20,8 @@ function debounce(fn, duration) {
 }
 
 function updateProjectsPathIfNeeded(projectId) {
+    if (!projectId) return;
+
     const newPath = `/${projectId}`;
 
     if (window.location.pathname !== newPath) {

diff --git a/packages/@best/frontend/src/modules/view/sidebar/sidebar.css b/packages/@best/frontend/src/modules/view/sidebar/sidebar.css
@@ -11,16 +11,9 @@
 
 .brand a {
     text-decoration: none;
-}
-
-.brand h1 {
-    font-size: 64px;
-    font-weight: bold;
+    display: block;
     text-align: center;
-}
-
-section {
-    margin-top: 55px;
+    margin: 3rem 0;
 }
 
 h3 {

diff --git a/packages/@best/frontend/src/modules/view/sidebar/sidebar.html b/packages/@best/frontend/src/modules/view/sidebar/sidebar.html
@@ -1,6 +1,10 @@
 <template>
     <header class="brand">
-        <a href="/"><h1>BEST</h1></a>
+        <a href="/">
+            <svg width="108" height="156" viewBox="0 0 27 39" fill="none" xmlns="http://www.w3.org/2000/svg" stroke-linejoin="round">
+                <path d="M1.5 4.18519V25.5C1.5 32.1274 6.87258 37.5 13.5 37.5H15.5C21.0228 37.5 25.5 33.0228 25.5 27.5V26.75C25.5 21.6414 21.3586 17.5 16.25 17.5H12.5C16.9183 17.5 20.5 13.9183 20.5 9.5C20.5 5.08172 16.9183 1.5 12.5 1.5H4.18519C2.7022 1.5 1.5 2.7022 1.5 4.18519Z" stroke="#ffffff" stroke-width="3"></path>
+            </svg>
+        </a>
     </header>
     <section class="projects">
         <h3>Projects</h3>

diff --git a/packages/@best/frontend/src/resources/favicon.ico b/packages/@best/frontend/src/resources/favicon.ico
diff --git a/packages/@best/runner-headless/package.json b/packages/@best/runner-headless/package.json
@@ -14,6 +14,7 @@
   "main": "build/index.js",
   "dependencies": {
     "@best/runner-abstract": "4.0.0-alpha3",
+    "@best/types": "4.0.0-alpha3",
     "puppeteer": "~1.17.0"
   },
   "files": [