fix!: upgrade puppeteer to v13.0.0

BREAKING CHANGE: Upgrade the headless Chrome version to `v97.0.4691.0`. Close: #292
salesforce · Apr 7, 2022 · a8238b8 · a8238b8
1 parent 0c3d9a8
commit a8238b8
Show file tree

Hide file tree

Showing 6 changed files with 114 additions and 86 deletions.
diff --git a/package.json b/package.json
@@ -45,7 +45,6 @@
     "@types/mkdirp": "^0.5.2",
     "@types/ncp": "^2.0.1",
     "@types/node": "~10.14.7",
-    "@types/puppeteer": "^2.0.0",
     "@types/rimraf": "^2.0.2",
     "@types/socket.io": "^2.1.2",
     "@types/socket.io-client": "^1.4.32",

diff --git a/packages/@best/runner-headless/package.json b/packages/@best/runner-headless/package.json
@@ -15,7 +15,10 @@
   "dependencies": {
     "@best/runner-abstract": "4.1.0",
     "@best/types": "4.1.0",
-    "puppeteer": "^5.3.1"
+    "puppeteer": "13.0.0"
+  },
+  "devDependencies": {
+    "@types/puppeteer": "5.4.4"
   },
   "files": [
     "build/**/*.js"

diff --git a/packages/@best/runner-headless/src/headless.ts b/packages/@best/runner-headless/src/headless.ts
@@ -24,7 +24,8 @@ const BROWSER_ARGS = [
     '--enable-precise-memory-info',
 ];
 
-const PUPPETEER_OPTIONS: puppeteer.LaunchOptions = { args: BROWSER_ARGS };
+
+const PUPPETEER_OPTIONS: puppeteer.BrowserLaunchArgumentOptions = { args: BROWSER_ARGS };
 
 function tempDir() {
     const TEMP_DIR_PREFIX = 'runner-headless-temp';
@@ -121,8 +122,8 @@ export default class HeadlessBrowser {
     static async getSpecs(): Promise<BrowserSpec[]> {
         // TODO: Create pupeteer test so we fail when upgrading
         return [
-            { name: 'chrome.headless', version: '80' },
-            { name: 'chrome', version: '80' }
+            { name: 'chrome.headless', version: '97' },
+            { name: 'chrome', version: '97' }
         ];
     }
 }
diff --git a/packages/best-benchmarks/best.config.js b/packages/best-benchmarks/best.config.js
@@ -8,7 +8,7 @@
 module.exports = {
     projectName: 'best-benchmark',
     metrics: ['script', 'aggregate', 'paint', 'layout'],
-    specs: { name: 'chrome.headless', version: 80 },
+    specs: { name: 'chrome.headless', version: 97 },
     runners: [
         {
             runner: "@best/runner-headless",

diff --git a/packages/lwc-example/best.config.js b/packages/lwc-example/best.config.js
@@ -13,7 +13,7 @@ module.exports = {
         }],
         ['rollup-plugin-replace', { 'process.env.NODE_ENV': JSON.stringify('production') }]
     ],
-    specs: { name: 'chrome.headless', version: 80 },
+    specs: { name: 'chrome.headless', version: 97 },
     runners: [
         {
             runner: "@best/runner-headless",