Skip to content

Commit

Permalink
fix!: upgrade puppeteer to v13.0.0
Browse files Browse the repository at this point in the history
BREAKING CHANGE: Upgrade the headless Chrome version to `v97.0.4691.0`.

Close: #292
  • Loading branch information
sf-v committed Apr 7, 2022
1 parent 0c3d9a8 commit a8238b8
Show file tree
Hide file tree
Showing 6 changed files with 114 additions and 86 deletions.
1 change: 0 additions & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,6 @@
"@types/mkdirp": "^0.5.2",
"@types/ncp": "^2.0.1",
"@types/node": "~10.14.7",
"@types/puppeteer": "^2.0.0",
"@types/rimraf": "^2.0.2",
"@types/socket.io": "^2.1.2",
"@types/socket.io-client": "^1.4.32",
Expand Down
5 changes: 4 additions & 1 deletion packages/@best/runner-headless/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,10 @@
"dependencies": {
"@best/runner-abstract": "4.1.0",
"@best/types": "4.1.0",
"puppeteer": "^5.3.1"
"puppeteer": "13.0.0"
},
"devDependencies": {
"@types/puppeteer": "5.4.4"
},
"files": [
"build/**/*.js"
Expand Down
7 changes: 4 additions & 3 deletions packages/@best/runner-headless/src/headless.ts
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,8 @@ const BROWSER_ARGS = [
'--enable-precise-memory-info',
];

const PUPPETEER_OPTIONS: puppeteer.LaunchOptions = { args: BROWSER_ARGS };

const PUPPETEER_OPTIONS: puppeteer.BrowserLaunchArgumentOptions = { args: BROWSER_ARGS };

function tempDir() {
const TEMP_DIR_PREFIX = 'runner-headless-temp';
Expand Down Expand Up @@ -121,8 +122,8 @@ export default class HeadlessBrowser {
static async getSpecs(): Promise<BrowserSpec[]> {
// TODO: Create pupeteer test so we fail when upgrading
return [
{ name: 'chrome.headless', version: '80' },
{ name: 'chrome', version: '80' }
{ name: 'chrome.headless', version: '97' },
{ name: 'chrome', version: '97' }
];
}
}
2 changes: 1 addition & 1 deletion packages/best-benchmarks/best.config.js
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@
module.exports = {
projectName: 'best-benchmark',
metrics: ['script', 'aggregate', 'paint', 'layout'],
specs: { name: 'chrome.headless', version: 80 },
specs: { name: 'chrome.headless', version: 97 },
runners: [
{
runner: "@best/runner-headless",
Expand Down
2 changes: 1 addition & 1 deletion packages/lwc-example/best.config.js
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ module.exports = {
}],
['rollup-plugin-replace', { 'process.env.NODE_ENV': JSON.stringify('production') }]
],
specs: { name: 'chrome.headless', version: 80 },
specs: { name: 'chrome.headless', version: 97 },
runners: [
{
runner: "@best/runner-headless",
Expand Down
Loading

0 comments on commit a8238b8

Please sign in to comment.