Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: New Frontend Dashboard #155

Merged
merged 24 commits into from
Jun 13, 2019
Merged

feat: New Frontend Dashboard #155

merged 24 commits into from
Jun 13, 2019

Conversation

jasonsilberman
Copy link
Contributor

@jasonsilberman jasonsilberman commented Jun 7, 2019

Details

Adding the new frontend and api-db packages.

Missing

  • This is still missing the GitHub integration and comparing commits but that will come later.

@git2gus
Copy link

git2gus bot commented Jun 7, 2019

Git2Gus App is installed but the .git2gus/config.json doesn't exists.

Copy link
Contributor

@diervo diervo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Its fine for now, we will re-review as progress is made.

packages/@best/api-db/.eslintrc.json Outdated Show resolved Hide resolved
@@ -28,6 +28,7 @@
"@commitlint/cli": "^8.0.0",
"@commitlint/config-conventional": "^8.0.0",
"@types/express": "^4.17.0",
"@types/globby": "^9.1.0",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Where this comes from?

Copy link
Contributor Author

@jasonsilberman jasonsilberman Jun 10, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My build was failing because TypeScript couldn't find the types for the globby module which is used in @best/cli and @best/store-fs. I would happily remove it if TypeScript would build without it.

@jasonsilberman jasonsilberman merged commit 5b4397b into v4 Jun 13, 2019
@jasonsilberman jasonsilberman deleted the jsilberman/frontend branch June 13, 2019 17:23
@jasonsilberman jasonsilberman restored the jsilberman/frontend branch June 15, 2019 01:52
@jasonsilberman jasonsilberman deleted the jsilberman/frontend branch June 15, 2019 01:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants