Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Update CI for v4 #168

Merged
merged 44 commits into from
Jul 2, 2019
Merged

fix: Update CI for v4 #168

merged 44 commits into from
Jul 2, 2019

Conversation

jasonsilberman
Copy link
Contributor

@jasonsilberman jasonsilberman commented Jun 28, 2019

Details

Fixes tests that were previously failing after redesign. Also moves to a projects config for Jest to work with frontend lwc tests.

@jasonsilberman jasonsilberman changed the title fix: tests now are successfully passing fix: Update Tests for v4 Jun 28, 2019
@jasonsilberman
Copy link
Contributor Author

@diervo when you have some time, please look into this. The tests keep failing when running on the CI, but will work if I ssh into the box and run them. Different tests are failing each time, but they all seem to have to do with running out of memory.

I tried running with yarn test --runInBand and yarn test --maxWorkers=2 but still neither works. Sometimes I am also getting messages about garbage collection issues from node.js.

I have looked at a bunch of issues online from jest or circleci, but still have not found anything that really works. I think there may be an issue with node 10 but I am really not sure.

@jasonsilberman jasonsilberman changed the title fix: Update Tests for v4 fix: Update CI for v4 Jul 2, 2019
@jasonsilberman jasonsilberman merged commit 0bd8075 into v4 Jul 2, 2019
@jasonsilberman jasonsilberman deleted the jsilberman/fix-tests branch July 2, 2019 23:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant