Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

git remote URL regexp is too restrictive #185

Closed
pmdartus opened this issue Jul 29, 2019 · 0 comments · Fixed by #188
Closed

git remote URL regexp is too restrictive #185

pmdartus opened this issue Jul 29, 2019 · 0 comments · Fixed by #188
Assignees
Labels

Comments

@pmdartus
Copy link
Member

Observation

This bug is a follow-up from #184. After following the getting started steps and set up the git, the best CLI was still complaining about the following error:

Error: Unable to parse git repo
    at getRepository (/Users/p.dartus/code/github/pmdartus/benchmark-ci-test/node_modules/@best/config/build/utils/git.js:25:15)
    at process._tickCallback (internal/process/next_tick.js:68:7)

The issue is originated from the git remote URI parsing which is not permissive enough.
https://github.com/salesforce/best/blob/master/packages/@best/config/src/utils/git.ts#L29

The regexp only accepts user name and repository names with alphabetic characters, while my repository name contains a dash.

Versions

  • node: 10.16.0
  • best: 4.0.0-alpha4
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants